Skip to content

Update test float from c python v3.12.7 #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

Update test float from c python v3.12.7 #5449

merged 2 commits into from
Dec 6, 2024

Conversation

key262yek
Copy link
Contributor

re-open PR for update test_float.py copied from CPython v3.12.7
#5104

@key262yek
Copy link
Contributor Author

I think CI fails related to new lint released.
https://blog.rust-lang.org/2024/11/28/Rust-1.83.0.html

youknowone
youknowone reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Could you rebase it on top of main just to make sure tests passes?

@key262yek key262yek force-pushed the update_test_float_from_CPython_v3.12.7 branch from 2255f6f to 0cf4534 Compare December 5, 2024 06:31
@key262yek
Copy link
Contributor Author

Finished rebase.

youknowone
youknowone approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit 97e5ec0 into RustPython:main Dec 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@key262yek @youknowone