Skip to content

_tkinter pt. 1 #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 23, 2025
Merged

_tkinter pt. 1 #5583

merged 8 commits into from
Mar 23, 2025

Conversation

arihant2math
Copy link
Collaborator

@arihant2math arihant2math commented Mar 5, 2025

Feature-gated because tk had to be installed in a not-very-easy manner to work on windows.

  • Add tkinter code
  • Add setup for tkinter feature/module
  • Add basic type stubs

@bjia56
Copy link

bjia56 commented Mar 5, 2025

Would tcl/tk binaries sourced from https://github.com/python/cpython-bin-deps/ be useful for Windows?

@arihant2math
Copy link
Collaborator Author

Yup, that is, I'll see if the crates I'm using will play nice with it.

@arihant2math arihant2math marked this pull request as ready for review March 13, 2025 17:25
@arihant2math arihant2math marked this pull request as draft March 13, 2025 18:13
@arihant2math arihant2math marked this pull request as ready for review March 13, 2025 18:14
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 9779de9 into RustPython:main Mar 23, 2025
21 of 22 checks passed
@arihant2math arihant2math deleted the tkinter-pt1 branch March 24, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants