Skip to content

Fix locals #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2019
Merged

Fix locals #599

merged 2 commits into from
Mar 5, 2019

Conversation

palaviv
Copy link
Contributor

@palaviv palaviv commented Mar 4, 2019

No description provided.

adrian17
adrian17 reviewed Mar 4, 2019
View reviewed changes
tests/snippets/builtin_locals.py

loc = locals()

assert loc['a'] == 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Could you do a similar test inside a function? This would help in case we try optimizing locals access in the future.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 😀

@windelbouwman windelbouwman merged commit 81a85cc into RustPython:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian17 adrian17 adrian17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palaviv @adrian17 @windelbouwman