Convert a bunch of string methods to new-args-style. #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly skipped the ones dealing with ints.
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
=========================================
- Coverage 41.25% 41.1% -0.16%
=========================================
Files 75 75
Lines 17096 17062 -34
Branches 4538 4507 -31
=========================================
- Hits 7053 7013 -40
- Misses 8005 8053 +48
+ Partials 2038 1996 -42
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly skipped the ones dealing with ints.