Skip to content

Convert a bunch of string methods to new-args-style. #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

adrian17
Copy link
Contributor

@adrian17 adrian17 commented Mar 5, 2019

Mostly skipped the ones dealing with ints.

Mostly skipped the ones dealing with ints.
@adrian17 adrian17 marked this pull request as ready for review March 5, 2019 19:44
@codecov-io
Copy link

Codecov Report

Merging #607 into master will decrease coverage by 0.15%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #607      +/-   ##
=========================================
- Coverage   41.25%   41.1%   -0.16%     
=========================================
  Files          75      75              
  Lines       17096   17062      -34     
  Branches     4538    4507      -31     
=========================================
- Hits         7053    7013      -40     
- Misses       8005    8053      +48     
+ Partials     2038    1996      -42
Impacted Files Coverage Δ
vm/src/obj/objstr.rs 34.46% <53.04%> (-3.09%) ⬇️
vm/src/function.rs 70.27% <75%> (+3.6%) ⬆️
vm/src/pyobject.rs 60.48% <0%> (+0.06%) ⬆️
vm/src/obj/objint.rs 47.34% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba25ef...e4e8b13. Read the comment docs.

@OddCoincidence OddCoincidence merged commit 06e17af into RustPython:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants