Skip to content

[WASM] Add row and column info of a syntax error to the JS error #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coolreader18
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #616 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   40.96%   40.93%   -0.03%     
==========================================
  Files          76       76              
  Lines       17213    17245      +32     
  Branches     4539     4512      -27     
==========================================
+ Hits         7051     7060       +9     
- Misses       8193     8234      +41     
+ Partials     1969     1951      -18
Impacted Files Coverage Δ
wasm/lib/src/browser_module.rs 0% <0%> (ø) ⬆️
wasm/lib/src/vm_class.rs 0% <0%> (ø) ⬆️
wasm/lib/src/convert.rs 0% <0%> (ø) ⬆️
vm/src/pyobject.rs 60.18% <0%> (+0.04%) ⬆️
vm/src/obj/objint.rs 47.94% <0%> (+0.49%) ⬆️
vm/src/obj/objstr.rs 35.23% <0%> (+0.88%) ⬆️
vm/src/stdlib/string.rs 23.03% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e9029...c563a6d. Read the comment docs.

@windelbouwman windelbouwman merged commit adde4e7 into RustPython:master Mar 9, 2019
@windelbouwman
Copy link
Contributor

Good error reporting is king!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants