Skip to content

Implement property attributes and functions #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

BenLewis-Seequent
Copy link

Adds the following attributes/methods to property:

  • fget
  • fset
  • fdel
  • getter
  • setter
  • deleter

@codecov-io
Copy link

Codecov Report

Merging #677 into master will increase coverage by 0.13%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   40.19%   40.33%   +0.13%     
==========================================
  Files          79       79              
  Lines       17441    17488      +47     
  Branches     4454     4470      +16     
==========================================
+ Hits         7011     7054      +43     
+ Misses       8597     8588       -9     
- Partials     1833     1846      +13
Impacted Files Coverage Δ
vm/src/obj/objnone.rs 55.26% <40%> (-2.32%) ⬇️
vm/src/obj/objproperty.rs 62.14% <68.29%> (+5.7%) ⬆️
vm/src/pyobject.rs 58.2% <72.72%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36204f2...3f301bd. Read the comment docs.

@OddCoincidence OddCoincidence merged commit 964a041 into RustPython:master Mar 14, 2019
@BenLewis-Seequent BenLewis-Seequent deleted the property branch March 29, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants