Do not block on sender thread join after timeout in producer.close() (dpkp#1974)

dpkp · web-flow · commit 1a91a54688cb · 2019-12-29T16:04:53.000-08:00
diff --git a/kafka/producer/kafka.py b/kafka/producer/kafka.py
@@ -445,7 +445,7 @@ def _unregister_cleanup(self):
         self._cleanup = None
 
     def __del__(self):
-        self.close(timeout=0)
+        self.close()
 
     def close(self, timeout=None):
         """Close this producer.
@@ -484,14 +484,10 @@ def close(self, timeout=None):
                     self._sender.join(timeout)
 
         if self._sender is not None and self._sender.is_alive():
-
             log.info("Proceeding to force close the producer since pending"
                      " requests could not be completed within timeout %s.",
                      timeout)
             self._sender.force_close()
-            # Only join the sender thread when not calling from callback.
-            if not invoked_from_callback:
-                self._sender.join()
 
         self._metrics.close()
         try:
