Skip to content

Commit 316d37d

Browse files
authored
Merge pull request miykael#45 from djarecka/1.0.1
testing nipype 1.0.1 before release I'm merging this to have the new version of neurodocker command (so it's not failing due to miniconda bugs). Will improve CircleCI in a separate PR
2 parents fe288ec + 56c4834 commit 316d37d

File tree

4 files changed

+17
-8
lines changed

4 files changed

+17
-8
lines changed

.circleci/config.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ jobs:
1111
name: docker build
1212
no_output_timeout: 60m
1313
command: |
14-
docker build -t djarecka/nipype_tutorial:$CIRCLE_BRANCH .
14+
for i in {1..5}; do
15+
docker build -t djarecka/nipype_tutorial:$CIRCLE_BRANCH . && break || sleep 15
16+
done
1517
- run:
1618
name: docker run
17-
no_output_timeout: 60m
19+
no_output_timeout: 90m
1820
command: |
1921
docker run -it --rm djarecka/nipype_tutorial:$CIRCLE_BRANCH pytest -v -s /home/neuro/nipype_tutorial/test_notebooks.py
2022

Dockerfile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
# Generated by Neurodocker v0.3.2.
1+
# Generated by Neurodocker v0.3.2-7-g4b0f32d.
22
#
33
# Thank you for using Neurodocker. If you discover any issues
44
# or ways to improve this software, please submit an issue or
55
# pull request on our GitHub repository:
66
# https://github.com/kaczmarj/neurodocker
77
#
8-
# Timestamp: 2017-12-28 23:39:47
8+
# Timestamp: 2018-02-26 18:15:43
99

1010
FROM neurodebian:stretch-non-free
1111

@@ -90,7 +90,7 @@ ENV CONDA_DIR=/opt/conda \
9090
PATH=/opt/conda/bin:$PATH
9191
RUN echo "Downloading Miniconda installer ..." \
9292
&& miniconda_installer=/tmp/miniconda.sh \
93-
&& curl -sSL --retry 5 -o $miniconda_installer https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh \
93+
&& curl -sSL --retry 5 -o $miniconda_installer https://repo.continuum.io/miniconda/Miniconda3-4.3.31-Linux-x86_64.sh \
9494
&& /bin/bash $miniconda_installer -b -p $CONDA_DIR \
9595
&& rm -f $miniconda_installer \
9696
&& conda config --system --prepend channels conda-forge \
@@ -210,6 +210,7 @@ RUN echo '{ \
210210
\n [ \
211211
\n "miniconda", \
212212
\n { \
213+
\n "miniconda_version": "4.3.31", \
213214
\n "conda_install": "python=3.6 pytest jupyter jupyterlab jupyter_contrib_nbextensions traits pandas matplotlib scikit-learn seaborn nbformat", \
214215
\n "pip_install": "https://github.com/nipy/nipype/tarball/master https://github.com/INCF/pybids/tarball/master nilearn datalad[full] nipy duecredit", \
215216
\n "env_name": "neuro", \
@@ -278,6 +279,6 @@ RUN echo '{ \
278279
\n ] \
279280
\n ] \
280281
\n ], \
281-
\n "generation_timestamp": "2017-12-28 23:39:47", \
282-
\n "neurodocker_version": "0.3.2" \
282+
\n "generation_timestamp": "2018-02-26 18:15:43", \
283+
\n "neurodocker_version": "0.3.2-7-g4b0f32d" \
283284
\n}' > /neurodocker/neurodocker_specs.json

create_dockerfile.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ docker run --rm kaczmarj/neurodocker:master generate -b neurodebian:stretch-non-
77
--add-to-entrypoint "source /etc/fsl/fsl.sh" \
88
--spm version=12 matlab_version=R2017a \
99
--user=neuro \
10-
--miniconda \
10+
--miniconda miniconda_version="4.3.31" \
1111
conda_install="python=3.6 pytest jupyter jupyterlab jupyter_contrib_nbextensions
1212
traits pandas matplotlib scikit-learn seaborn nbformat" \
1313
pip_install="https://github.com/nipy/nipype/tarball/master

test_notebooks.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
from nbconvert.preprocessors import ExecutePreprocessor
77
from nbconvert.preprocessors.execute import CellExecutionError
88

9+
10+
def test_version():
11+
import nipype
12+
print("nipype version: ", nipype.__version__)
13+
14+
915
def _notebook_run(path):
1016
"""
1117
Execute a notebook via nbconvert and collect output.

0 commit comments

Comments
 (0)