ref(replay): Stop calling _updateSessionFromEvent (getsentry#6510)

mydea · web-flow · commit c2eb012865ae · 2022-12-13T15:33:13.000+01:00
This can't really have an impact, as that only does stuff when the event has `exception`, which a replay does not.
diff --git a/docs/event-sending.md b/docs/event-sending.md
@@ -84,7 +84,6 @@ This document gives an outline for how event sending works, and which which plac
       * `baseclient._applyIntegrationsMetadata()`
       * `scope.applyToEvent()`
       * `baseclient._normalizeEvent()`
-    * `baseclient._updateSessionFromEvent()`
   * `createReplayEnvelope()`
     * `createEnvelope()`
   * `transport.send()`
diff --git a/packages/replay/src/util/getReplayEvent.ts b/packages/replay/src/util/getReplayEvent.ts
@@ -18,12 +18,6 @@ export async function getReplayEvent({
   // @ts-ignore private api
   const preparedEvent: Event = await client._prepareEvent(event, { event_id }, scope);
 
-  const session = scope && scope.getSession();
-  if (session) {
-    // @ts-ignore private api
-    client._updateSessionFromEvent(session, preparedEvent);
-  }
-
   preparedEvent.sdk = {
     ...preparedEvent.sdk,
     ...REPLAY_SDK_INFO,
diff --git a/rollup/plugins/bundlePlugins.js b/rollup/plugins/bundlePlugins.js
@@ -106,7 +106,6 @@ export function makeTerserPlugin() {
           '_support',
           // TODO: Get rid of these once we use the SDK to send replay events
           '_prepareEvent', // replay uses client._prepareEvent
-          '_updateSessionFromEvent', // replay client._updateSessionFromEvent
         ],
       },
     },
