Make tests independent from each other

greg0ire · greg0ire · commit 00883fc4099e · 2019-04-07T23:05:09.000+02:00
Environment variables set in a test need to be restored to their
previous values or unset if we want to be able to run tests
independently.
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -41,6 +41,13 @@ class ApplicationTest extends TestCase
 {
     protected static $fixturesPath;
 
+    private $colSize;
+
+    protected function setUp()
+    {
+        $this->colSize = getenv('COLUMNS');
+    }
+
     public static function setUpBeforeClass()
     {
         self::$fixturesPath = realpath(__DIR__.'/Fixtures/');
@@ -383,6 +390,7 @@ public function testFindWithCommandLoader()
      */
     public function testFindWithAmbiguousAbbreviations($abbreviation, $expectedExceptionMessage)
     {
+        putenv('COLUMNS=120');
         if (method_exists($this, 'expectException')) {
             $this->expectException('Symfony\Component\Console\Exception\CommandNotFoundException');
             $this->expectExceptionMessage($expectedExceptionMessage);
@@ -468,6 +476,7 @@ public function provideInvalidCommandNamesSingle()
 
     public function testFindAlternativeExceptionMessageMultiple()
     {
+        putenv('COLUMNS=120');
         $application = new Application();
         $application->add(new \FooCommand());
         $application->add(new \Foo1Command());
@@ -1692,6 +1701,7 @@ public function testErrorIsRethrownIfNotHandledByConsoleErrorEventWithCatchingEn
 
     protected function tearDown()
     {
+        putenv($this->colSize ? 'COLUMNS' : 'COLUMNS='.$this->colSize);
         putenv('SHELL_VERBOSITY');
         unset($_ENV['SHELL_VERBOSITY']);
         unset($_SERVER['SHELL_VERBOSITY']);
diff --git a/src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php b/src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php
@@ -21,6 +21,19 @@
  */
 class ProgressBarTest extends TestCase
 {
+    private $colSize;
+
+    protected function setUp()
+    {
+        $this->colSize = getenv('COLUMNS');
+        putenv('COLUMNS=120');
+    }
+
+    protected function tearDown()
+    {
+        putenv($this->colSize ? 'COLUMNS' : 'COLUMNS='.$this->colSize);
+    }
+
     public function testMultipleStart()
     {
         $bar = new ProgressBar($output = $this->getOutputStream());
diff --git a/src/Symfony/Component/Console/Tests/Style/SymfonyStyleTest.php b/src/Symfony/Component/Console/Tests/Style/SymfonyStyleTest.php
@@ -26,17 +26,19 @@ class SymfonyStyleTest extends TestCase
     protected $command;
     /** @var CommandTester */
     protected $tester;
+    private $colSize;
 
     protected function setUp()
     {
+        $this->colSize = getenv('COLUMNS');
         putenv('COLUMNS=121');
         $this->command = new Command('sfstyle');
         $this->tester = new CommandTester($this->command);
     }
 
     protected function tearDown()
     {
-        putenv('COLUMNS');
+        putenv($this->colSize ? 'COLUMNS' : 'COLUMNS='.$this->colSize);
         $this->command = null;
         $this->tester = null;
     }
diff --git a/src/Symfony/Component/Console/Tests/TerminalTest.php b/src/Symfony/Component/Console/Tests/TerminalTest.php
@@ -16,6 +16,15 @@
 
 class TerminalTest extends TestCase
 {
+    private $colSize;
+    private $lineSize;
+
+    protected function setUp()
+    {
+        $this->colSize = getenv('COLUMNS');
+        $this->lineSize = getenv('LINES');
+    }
+
     public function test()
     {
         putenv('COLUMNS=100');
@@ -31,6 +40,12 @@ public function test()
         $this->assertSame(60, $terminal->getHeight());
     }
 
+    protected function tearDown()
+    {
+        putenv($this->colSize ? 'COLUMNS' : 'COLUMNS='.$this->colSize);
+        putenv($this->lineSize ? 'LINES' : 'LINES='.$this->lineSize);
+    }
+
     public function test_zero_values()
     {
         putenv('COLUMNS=0');

Original file line number	Diff line number	Diff line change
`@@ -26,17 +26,19 @@ class SymfonyStyleTest extends TestCase`
`26`	`26`	`protected $command;`
`27`	`27`	`/** @var CommandTester */`
`28`	`28`	`protected $tester;`
	`29`	`+ private $colSize;`
`29`	`30`
`30`	`31`	`protected function setUp()`
`31`	`32`	`{`
	`33`	`+ $this->colSize = getenv('COLUMNS');`
`32`	`34`	`putenv('COLUMNS=121');`
`33`	`35`	`$this->command = new Command('sfstyle');`
`34`	`36`	`$this->tester = new CommandTester($this->command);`
`35`	`37`	`}`
`36`	`38`
`37`	`39`	`protected function tearDown()`
`38`	`40`	`{`
`39`		`- putenv('COLUMNS');`
	`41`	`+ putenv($this->colSize ? 'COLUMNS' : 'COLUMNS='.$this->colSize);`
`40`	`42`	`$this->command = null;`
`41`	`43`	`$this->tester = null;`
`42`	`44`	`}`