drop support for old Symfony versions #67
Conversation
|
@garak Thanks for taking the time to make this pull request. Can you take a look at the travis build? I seems to be failing. |
8adb24d to
5d9ddb2
Compare
|
I made some changes and squashed. Now, as you can see in travis, there's a small problem with php 5.6, and the error is a bit weird: |
|
It's related to this issue: symfony/symfony#18893 We should change our composer.json requirement: -"symfony/dependency-injection": "~2.7 || ~3.3 || ~4.0",
+"symfony/dependency-injection": "~2.7.16 || ~3.3 || ~4.0",It will proceed further, but still fails later on with a different issue. |
|
The second issue is fixed when require a minimum version of 3.0.1 for message-bus -"simple-bus/message-bus": "~3.0",
+"simple-bus/message-bus": "~3.0.1", |
|
It's all green now! 💚 |
| "doctrine/doctrine-bundle": "~1.0", | ||
| "symfony/monolog-bridge": "~2.3 || ~3.0 || ~4.0", | ||
| "symfony/monolog-bundle": "~2.3 || ~3.0 " | ||
| "symfony/monolog-bridge": "~2.8 || ~3.2 || ~4.0", |
There was a problem hiding this comment.
It looks like monolog-bridge is not following the same versions of Symfony.
|
We'll close this PR because we are moving SimpleBus to a monorepo. We'll take care of it there. |
This should fix #51
This PR is also sorting dependencies.