Use shutil.which instead of sh.which (kivy#2637)

misl6 · SomberNight · commit ed4a23cdd256 · 2022-10-14T15:04:53.000Z
diff --git a/pythonforandroid/build.py b/pythonforandroid/build.py
@@ -392,7 +392,7 @@ def prepare_build_environment(self,
         check_ndk_api(ndk_api, self.android_api)
 
         # path to some tools
-        self.ccache = sh.which("ccache")
+        self.ccache = shutil.which("ccache")
         if not self.ccache:
             info('ccache is missing, the build will not be optimized in the '
                  'future.')
@@ -463,7 +463,7 @@ def prepare_build_environment(self,
 
         for executable in ("pkg-config", "autoconf", "automake", "libtoolize",
                            "tar", "bzip2", "unzip", "make", "gcc", "g++"):
-            if not sh.which(executable):
+            if not shutil.which(executable):
                 warning(f"Missing executable: {executable} is not installed")
 
         if not ok:
@@ -1012,7 +1012,7 @@ def copylibs_function(soname, objs_paths, extra_link_dirs=None, env=None):
     elif 'READELF' in os.environ:
         readelf = os.environ['READELF']
     else:
-        readelf = sh.which('readelf').strip()
+        readelf = shutil.which('readelf').strip()
     readelf = sh.Command(readelf).bake('-d')
 
     dest = dirname(soname)
diff --git a/pythonforandroid/recipes/lapack/__init__.py b/pythonforandroid/recipes/lapack/__init__.py
@@ -9,6 +9,7 @@
 from multiprocessing import cpu_count
 from os.path import join
 import sh
+import shutil
 
 
 class LapackRecipe(Recipe):
@@ -25,7 +26,7 @@ def get_recipe_env(self, arch):
         sysroot = f"{self.ctx.ndk_dir}/platforms/{env['NDK_API']}/{arch.platform_dir}"
         FC = f"{env['TOOLCHAIN_PREFIX']}-gfortran"
         env['FC'] = f'{FC} --sysroot={sysroot}'
-        if sh.which(FC) is None:
+        if shutil.which(FC) is None:
             raise BuildInterruptingException(f"{FC} not found. See https://github.com/mzakharo/android-gfortran")
         return env
 
diff --git a/pythonforandroid/recipes/numpy/__init__.py b/pythonforandroid/recipes/numpy/__init__.py
@@ -5,6 +5,7 @@
 from os.path import join
 import glob
 import sh
+import shutil
 
 
 class NumpyRecipe(CompiledComponentsPythonRecipe):
diff --git a/pythonforandroid/recipes/python3/__init__.py b/pythonforandroid/recipes/python3/__init__.py
@@ -6,7 +6,7 @@
 from os import environ, utime
 from os.path import dirname, exists, join
 from pathlib import Path
-from shutil import copy2
+import shutil
 
 from pythonforandroid.logger import info, warning, shprint
 from pythonforandroid.patching import version_starts_with
@@ -73,7 +73,7 @@ class Python3Recipe(TargetPythonRecipe):
         ('patches/py3.8.1.patch', version_starts_with("3.9"))
     ]
 
-    if sh.which('lld') is not None:
+    if shutil.which('lld') is not None:
         patches = patches + [
             ("patches/py3.7.1_fix_cortex_a8.patch", version_starts_with("3.7")),
             ("patches/py3.8.1_fix_cortex_a8.patch", version_starts_with("3.8")),
@@ -209,7 +209,7 @@ def get_recipe_env(self, arch=None, with_flags_in_cc=True):
         )
 
         env['LDFLAGS'] = env.get('LDFLAGS', '')
-        if sh.which('lld') is not None:
+        if shutil.which('lld') is not None:
             # Note: The -L. is to fix a bug in python 3.7.
             # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234409
             env['LDFLAGS'] += ' -L. -fuse-ld=lld'
@@ -381,7 +381,7 @@ def create_python_bundle(self, dirn, arch):
         info("Copy {} files into the bundle".format(len(module_filens)))
         for filen in module_filens:
             info(" - copy {}".format(filen))
-            copy2(filen, modules_dir)
+            shutil.copy2(filen, modules_dir)
 
         # zip up the standard library
         stdlib_zip = join(dirn, 'stdlib.zip')
@@ -409,7 +409,7 @@ def create_python_bundle(self, dirn, arch):
             for filen in filens:
                 info(" - copy {}".format(filen))
                 ensure_dir(join(dirn, 'site-packages', dirname(filen)))
-                copy2(filen, join(dirn, 'site-packages', filen))
+                shutil.copy2(filen, join(dirn, 'site-packages', filen))
 
         # copy the python .so files into place
         python_build_dir = join(self.get_build_dir(arch.arch),
