Skip to content

Commit 0305447

Browse files
committed
Collapse HasToString
1 parent 2eb4069 commit 0305447

File tree

3 files changed

+9
-48
lines changed

3 files changed

+9
-48
lines changed

hamcrest-library/src/main/java/org/hamcrest/Matchers.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.hamcrest;
22

3+
import org.hamcrest.object.MatchObjects;
34
import org.hamcrest.text.MatchStrings;
45
import org.hamcrest.xml.MatchXml;
56

@@ -1355,7 +1356,7 @@ public static org.hamcrest.Matcher<java.lang.String> stringContainsInOrder(java.
13551356
* @param toStringMatcher the matcher used to verify the toString result
13561357
*/
13571358
public static <T> org.hamcrest.Matcher<T> hasToString(org.hamcrest.Matcher<? super java.lang.String> toStringMatcher) {
1358-
return org.hamcrest.object.HasToString.hasToString(toStringMatcher);
1359+
return MatchObjects.hasToString(toStringMatcher);
13591360
}
13601361

13611362
/**
@@ -1367,7 +1368,7 @@ public static <T> org.hamcrest.Matcher<T> hasToString(org.hamcrest.Matcher<? sup
13671368
* @param expectedToString the expected toString result
13681369
*/
13691370
public static <T> org.hamcrest.Matcher<T> hasToString(java.lang.String expectedToString) {
1370-
return org.hamcrest.object.HasToString.hasToString(expectedToString);
1371+
return MatchObjects.hasToString(expectedToString);
13711372
}
13721373

13731374
/**

hamcrest-library/src/main/java/org/hamcrest/object/HasToString.java

Lines changed: 0 additions & 43 deletions
This file was deleted.

hamcrest-library/src/main/java/org/hamcrest/object/MatchObjects.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.hamcrest.object;
22

3+
import org.hamcrest.FeatureMatcher;
34
import org.hamcrest.Matcher;
45
import org.hamcrest.collection.IsIn;
56
import org.hamcrest.comparator.ComparatorMatcherBuilder;
@@ -134,6 +135,7 @@ public static Matcher<Object> nullValue() {
134135
*
135136
* @param type dummy parameter used to infer the generic type of the returned matcher
136137
*/
138+
@SuppressWarnings("UnusedParameters")
137139
public static <T> Matcher<T> nullValue(Class<T> type) {
138140
return new IsNull<>();
139141
}
@@ -264,9 +266,10 @@ public static <T extends Comparable<? super T>> Matcher<T> lessThanOrEqualTo(T v
264266
* @param toStringMatcher the matcher used to verify the toString result
265267
*/
266268
public static <T> Matcher<T> hasToString(org.hamcrest.Matcher<? super String> toStringMatcher) {
267-
return org.hamcrest.object.HasToString.hasToString(toStringMatcher);
269+
return new FeatureMatcher<T, String>(toStringMatcher, "with toString()", "toString()") {
270+
@Override protected String featureValueOf(T actual) { return String.valueOf(actual); }
271+
};
268272
}
269-
270273
/**
271274
* Creates a matcher that matches any examined object whose <code>toString</code> method
272275
* returns a value equalTo the specified string.
@@ -276,7 +279,7 @@ public static <T> Matcher<T> hasToString(org.hamcrest.Matcher<? super String> to
276279
* @param expectedToString the expected toString result
277280
*/
278281
public static <T> Matcher<T> hasToString(String expectedToString) {
279-
return org.hamcrest.object.HasToString.hasToString(expectedToString);
282+
return hasToString(equalTo(expectedToString));
280283
}
281284

282285
/**

0 commit comments

Comments
 (0)