visualpython#9 - always enable apply button (deleted disable parts)

minjk-bl · minjk-bl · commit 61711fd1cf96 · 2021-05-10T16:26:07.000+09:00
diff --git a/src/api_block/blockContainer.js b/src/api_block/blockContainer.js
@@ -298,8 +298,6 @@ define([
         var passChecking = false;
         if (block) {
             if (block.isModified) {
-                // set apply button enabled
-                $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).removeClass('disabled');
                 // show title alert
                 $(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'block');
             } else {
@@ -338,20 +336,16 @@ define([
                         block.state_backup['isFinally'] = nowState['isFinally'];
                 }
                 if (!passChecking && JSON.stringify(nowState) != JSON.stringify(block.state_backup)) {
-                    // set apply button enabled
-                    $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).removeClass('disabled');
                     // show title alert
                     $(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'block');
 
                     // set this block to isModified = true
                     block.isModified = true;
                 } else {
-                    $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).addClass('disabled');
                     $(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'none');
                 }
             }
         } else {
-            $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).addClass('disabled');
             $(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'none');
         }
     }
diff --git a/src/api_block/index.html b/src/api_block/index.html
@@ -142,7 +142,7 @@
                             <div id="vp_apiblock_board_option_cancel_button" class="vp-button cancel vp-apiblock-option-button vp-apiblock-option-cancel-button">
                             Cancel
                             </div>
-                            <div id="vp_apiblock_board_option_apply_button" class="vp-button disabled activated vp-apiblock-option-button vp-apiblock-option-apply-button">
+                            <div id="vp_apiblock_board_option_apply_button" class="vp-button activated vp-apiblock-option-button vp-apiblock-option-apply-button">
                             Apply
                             </div>
                         </div>
diff --git a/src/api_block/init.js b/src/api_block/init.js
@@ -443,11 +443,6 @@ define([
 
         /** option page - apply 버튼 클릭 함수 바인딩 */
         $(document).on(STR_CLICK, VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON, function() {
-            // if disabled, do nothing
-            if ($(this).hasClass('disabled')) {
-                return;
-            }
-
             blockContainer.applyBlock();
         });
 

Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,6 @@ define([`
`298`	`298`	`var passChecking = false;`
`299`	`299`	`if (block) {`
`300`	`300`	`if (block.isModified) {`
`301`		`- // set apply button enabled`
`302`		`- $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).removeClass('disabled');`
`303`	`301`	`// show title alert`
`304`	`302`	`$(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'block');`
`305`	`303`	`} else {`
`@@ -338,20 +336,16 @@ define([`
`338`	`336`	`block.state_backup['isFinally'] = nowState['isFinally'];`
`339`	`337`	`}`
`340`	`338`	`if (!passChecking && JSON.stringify(nowState) != JSON.stringify(block.state_backup)) {`
`341`		`- // set apply button enabled`
`342`		`- $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).removeClass('disabled');`
`343`	`339`	`// show title alert`
`344`	`340`	`$(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'block');`
`345`	`341`
`346`	`342`	`// set this block to isModified = true`
`347`	`343`	`block.isModified = true;`
`348`	`344`	`} else {`
`349`		`- $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).addClass('disabled');`
`350`	`345`	`$(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'none');`
`351`	`346`	`}`
`352`	`347`	`}`
`353`	`348`	`} else {`
`354`		`- $(VP_ID_PREFIX + VP_APIBLOCK_BOARD_OPTION_APPLY_BUTTON).addClass('disabled');`
`355`	`349`	`$(VP_CLASS_PREFIX + 'vp-apiblock-option-new-to-save').css('display', 'none');`
`356`	`350`	`}`
`357`	`351`	`}`