Fix bug found by SonarQube in replaceAll (#417)

billoneil · web-flow · commit 92ba117083e7 · 2021-07-22T07:34:35.000-04:00
diff --git a/stubbornjava-webapp/src/main/java/com/stubbornjava/webapp/github/FileContentUtils.java b/stubbornjava-webapp/src/main/java/com/stubbornjava/webapp/github/FileContentUtils.java
@@ -47,8 +47,8 @@ public static Map<String, FileContent.Section> parseContent(String raw) {
                                 int indentSpaces = matcher.group(1).length();
                                 StringBuilder sb = new StringBuilder();
                                 lines.stream().forEach(line -> {
-                                    line.replaceAll("\t", "    "); // replace tabs with 4 spaces
-                                    sb.append(line.substring(Math.min(line.length(), indentSpaces)) + "\n");
+                                    String replaced = line.replaceAll("\t", "    "); // replace tabs with 4 spaces
+                                    sb.append(line.substring(Math.min(replaced.length(), indentSpaces)) + "\n");
                                 });
                                 sections.put(sectionName, new FileContent.Section(startLineNum, endLineNum, sb.toString()));
                             }
