Skip to content

images always centered using custom renderer #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martipello opened this issue Jul 6, 2020 · 1 comment
Closed

images always centered using custom renderer #346

martipello opened this issue Jul 6, 2020 · 1 comment

Comments

@martipello
Copy link

martipello commented Jul 6, 2020

when using the custom renderer to show an image

customRender: {
'img': (renderContext, child, attributes, _) {
var imageUrl = attributes['h2'];
return Text('H2');
},
'img': (renderContext, child, attributes, _) {
var imageUrl = attributes['src'];
return Text('IMAGE');
},
},

this makes the image centered no matter what we try to do to it, if we instead replace it just for a text widget it seems its placed to the left with a large amount of padding regardless of what we try to do, eg: wrapping it in flex widgets like rows

https://drive.google.com/file/d/17PKWI4OT0rKoT7FrI-m2jEdwu60P52IP/view?usp=sharing

@erickok
Copy link
Contributor

erickok commented Feb 8, 2021

This should be fixed - thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants