Skip to content

Web support #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nietsmmar opened this issue Jun 7, 2021 · 6 comments
Closed

Web support #725

nietsmmar opened this issue Jun 7, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@nietsmmar
Copy link

Is it planned to support web platform? This would be really great!

@nietsmmar nietsmmar added the enhancement New feature or request label Jun 7, 2021
@tneotia
Copy link
Contributor

tneotia commented Jun 7, 2021

We have full support for web even though pub.dev doesn't say that. Try it out! :)

@ryan-berger
Copy link
Contributor

@tneotia What would it take to get Pub to say that we support it? Is it something that I need to do?

@tneotia
Copy link
Contributor

tneotia commented Jun 7, 2021

@ryan-berger nothing you can do at the moment.

The issue is that we use webview_flutter which does not have support for web. As soon as Pub sees that import, it automatically says we don't support web even though we have specifically created an iframe implementation for web (and therefore have full support).

This won't be fixed until modularization is merged (#661) because that import will be removed from the core package.

I have this same issue in my own package on Pub, it only shows I have support for mobile even though I support web as well. Maybe it would be useful to put support for web in the "description" of the package in pubspec? Up to you.

@nietsmmar
Copy link
Author

nietsmmar commented Jun 7, 2021

@tneotia Oh wow cool! Actually I did try it and got this error messages:
2021-06-07_21-11
which is shown in my generated_plugin_registrant.dart

which is why I checked and then saw in the 'scores' that it is not supported. Do I need to somehow add video_player_web and wakelock_web on my own as dependencies?

@nietsmmar
Copy link
Author

Okay, nevermind. I tried again and now it somehow works. I don't know what went wrong there the first time. Thanks for this great plugin and the fast response!

@tneotia
Copy link
Contributor

tneotia commented Jun 9, 2021

@erickok this can be closed.

@erickok erickok closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants