Skip to content

Fix block elements from producing bottom spacing #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2021
Merged

Fix block elements from producing bottom spacing #947

merged 3 commits into from
Dec 16, 2021

Conversation

erickok
Copy link
Contributor

@erickok erickok commented Dec 15, 2021

Block style elements in table cells (td/th) should not produce block-like bottom spacing.

Example html:

<p><br></p><table class=\"se-table-size-100 vrt-table vrt-table--no-offset\"><thead><tr><th><div>Nummer</div></th><th><div>Naam</div></th><th><div>Score</div></th></tr></thead><tbody><tr><td><div>1</div></td><td><div>Bergsvand</div></td><td><div>2</div></td></tr><tr><td><div>2</div></td><td><div>Graham Hansen</div></td><td><div>1</div></td></tr><tr><td><div>3</div></td><td><div>Terland&nbsp;</div></td><td><div>1</div></td></tr></tbody></table><p><br></p>

Should produce:


Nummer
Naam
Score
1
Bergsvand
2
2
Graham Hansen
1
3
Terland 
1


But instead it was producing:
Screenshot 2021-12-15 at 16 30 19

After my fix it looks like:
Screenshot 2021-12-15 at 16 29 43

@erickok erickok merged commit 9648c96 into Sub6Resources:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erickok