Resolved with Suggested changes

satyabarghav · satyabarghav · commit 0a7a2682f007 · 2023-10-22T20:06:53.000+05:30
diff --git a/pom.xml b/pom.xml
@@ -28,6 +28,12 @@
     </dependencyManagement>
 
     <dependencies>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-api</artifactId>
+            <version>5.8.2</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter</artifactId>
diff --git a/src/main/java/com/thealgorithms/maths/HeronsFormula.java b/src/main/java/com/thealgorithms/maths/HeronsFormula.java
@@ -14,7 +14,7 @@ public final class HeronsFormula {
      * here s is called semi-perimeter and it is the half of the perimeter (i.e; s = (s1+s2+s3)/2)
      * @author satyabarghav
      */
-    private HeronsFormula(){
+    private HeronsFormula() {
     }
     public static double Herons(final double a, final double b, final double c) {
         if (!(a + b > c && b + c > a && c + a > b)) {
@@ -24,7 +24,4 @@ public static double Herons(final double a, final double b, final double c) {
             return Math.sqrt((s) * (s - a) * (s - b) * (s - c));
         }
     }
-    public static void main(String[] args){
-        System.out.println(Herons(1, 2, 3));
-    }
 }
diff --git a/src/test/java/com/thealgorithms/maths/HeronsFormulaTest.java b/src/test/java/com/thealgorithms/maths/HeronsFormulaTest.java
@@ -1,7 +1,6 @@
 package com.thealgorithms.maths;
 
-import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.*;
 
 public class HeronsFormulaTest {
 
@@ -26,9 +25,7 @@ void test4() {
     }
 
     @Test
-    void test5() {
-        assertThrows(IllegalArgumentException.class, () -> {
-            HeronsFormula.calculateArea(1, 2, 3);
-        });
+    public void testCalculateAreaWithInvalidInput() {
+        Assertions.assertThrows(IllegalArgumentException.class, () -> { HeronsFormula.Herons(1, 2, 3); });
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public final class HeronsFormula {`
`14`	`14`	`* here s is called semi-perimeter and it is the half of the perimeter (i.e; s = (s1+s2+s3)/2)`
`15`	`15`	`* @author satyabarghav`
`16`	`16`	`*/`
`17`		`- private HeronsFormula(){`
	`17`	`+ private HeronsFormula() {`
`18`	`18`	`}`
`19`	`19`	`public static double Herons(final double a, final double b, final double c) {`
`20`	`20`	`if (!(a + b > c && b + c > a && c + a > b)) {`
`@@ -24,7 +24,4 @@ public static double Herons(final double a, final double b, final double c) {`
`24`	`24`	`return Math.sqrt((s) * (s - a) * (s - b) * (s - c));`
`25`	`25`	`}`
`26`	`26`	`}`
`27`		`- public static void main(String[] args){`
`28`		`- System.out.println(Herons(1, 2, 3));`
`29`		`- }`
`30`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`package com.thealgorithms.maths;`
`2`	`2`
`3`		`-import org.junit.jupiter.api.Assertions;`
`4`		`-import org.junit.jupiter.api.Test;`
	`3`	`+import org.junit.jupiter.api.*;`
`5`	`4`
`6`	`5`	`public class HeronsFormulaTest {`
`7`	`6`
`@@ -26,9 +25,7 @@ void test4() {`
`26`	`25`	`}`
`27`	`26`
`28`	`27`	`@Test`
`29`		`- void test5() {`
`30`		`- assertThrows(IllegalArgumentException.class, () -> {`
`31`		`- HeronsFormula.calculateArea(1, 2, 3);`
`32`		`- });`
	`28`	`+ public void testCalculateAreaWithInvalidInput() {`
	`29`	`+ Assertions.assertThrows(IllegalArgumentException.class, () -> { HeronsFormula.Herons(1, 2, 3); });`
`33`	`30`	`}`
`34`	`31`	`}`