Merge pull request #1253 from EAlexa/master

yanglbme · web-flow · commit 40eee1c5af90 · 2020-04-08T17:47:50.000+08:00
optimization
diff --git a/Conversions/DecimalToBinary.java b/Conversions/DecimalToBinary.java
@@ -35,6 +35,7 @@ public static void conventionalConversion() {
             n /= 2;
         } //converting decimal to binary
         System.out.println("\tBinary number: " + b);
+        input.close();
     }
 
     /**
diff --git a/Conversions/RomanToInteger.java b/Conversions/RomanToInteger.java
@@ -4,7 +4,13 @@
 
 public class RomanToInteger {
 
-    private static Map<Character, Integer> map = new HashMap<Character, Integer>() {{
+    private static Map<Character, Integer> map = new HashMap<Character, Integer>() {
+        /**
+        *
+        */
+        private static final long serialVersionUID = 87605733047260530L;
+
+        {
         put('I', 1);
         put('V', 5);
         put('X', 10);
diff --git a/DataStructures/Buffers/CircularBuffer.java b/DataStructures/Buffers/CircularBuffer.java
@@ -26,12 +26,15 @@ private int getTrueIndex(int i) {
         return i % _buffer_size;
     }
 
+    
     public Character readOutChar() {
         Character result = null;
 
+        
         //if we have data to read
         if (_readable_data.get() > 0) {
-            result = new Character(_buffer[getTrueIndex(_read_index)]);
+            
+            result = Character.valueOf(_buffer[getTrueIndex(_read_index)]);
             _readable_data.decrementAndGet();
             _read_index++;
         }
diff --git a/DataStructures/Graphs/ConnectedComponent.java b/DataStructures/Graphs/ConnectedComponent.java
@@ -108,7 +108,7 @@ public ArrayList<Node> depthFirstSearch(Node n, ArrayList<Node> visited) {
 public class ConnectedComponent {
 
     public static void main(String[] args) {
-        Graph graphChars = new Graph();
+        Graph<Character> graphChars = new Graph<>();
 
         // Graph 1
         graphChars.addEdge('a', 'b');
@@ -123,7 +123,7 @@ public static void main(String[] args) {
 
         graphChars.addEdge('w', 'w');
 
-        Graph graphInts = new Graph();
+        Graph<Integer> graphInts = new Graph<>();
 
         // Graph 2
         graphInts.addEdge(1, 2);
diff --git a/DataStructures/Graphs/Cycles.java b/DataStructures/Graphs/Cycles.java
@@ -10,7 +10,7 @@ class Cycle {
     private int[][] adjacencyMatrix;
     private boolean[] visited;
     ArrayList<ArrayList<Integer>> cycles = new ArrayList<ArrayList<Integer>>();
-    private boolean[] finalCycles;
+    
 
     public Cycle() {
         Scanner in = new Scanner(System.in);
@@ -34,6 +34,7 @@ public Cycle() {
             end = in.nextInt();
             adjacencyMatrix[start][end] = 1;
         }
+        in.close();
 
     }
 
diff --git a/DataStructures/Graphs/PrimMST.java b/DataStructures/Graphs/PrimMST.java
@@ -1,7 +1,5 @@
 package DataStructures.Graphs;
 
-import java.lang.*;
-
 /**
  * A Java program for Prim's Minimum Spanning Tree (MST) algorithm.
  * adjacency matrix representation of the graph
diff --git a/DataStructures/HashMap/Hashing/LinkedList.java b/DataStructures/HashMap/Hashing/LinkedList.java
@@ -12,7 +12,6 @@ public LinkedList() {
 
 	public void insert(int data) {
 
-		Node temp = Head;
 		Node newnode = new Node(data);
 	
 		size++;
diff --git a/DataStructures/HashMap/Hashing/Main.java b/DataStructures/HashMap/Hashing/Main.java
@@ -8,16 +8,15 @@ public static void main(String[] args) {
 		int choice, key;
 
 		HashMap h = new HashMap(7);
+		Scanner In = new Scanner(System.in);
 
 		while (true) {
 			System.out.println("Enter your Choice :");
 			System.out.println("1. Add Key");
 			System.out.println("2. Delete Key");
 			System.out.println("3. Print Table");
 			System.out.println("4. Exit");
-
-			Scanner In = new Scanner(System.in);
-
+			
 			choice = In.nextInt();
 
 			switch (choice) {
@@ -39,10 +38,11 @@ public static void main(String[] args) {
 					break;
 				}
 				case 4: {
+					In.close();
 					return;
 				}	
 			}
-			In.close();
+			
 		}
 	}
 }
diff --git a/DataStructures/Lists/CursorLinkedList.java b/DataStructures/Lists/CursorLinkedList.java
@@ -4,6 +4,7 @@
 
 public class CursorLinkedList<T> {
 
+    
     private static class Node<T> {
 
         T element;
@@ -13,20 +14,16 @@ private static class Node<T> {
             this.element = element;
             this.next = next;
         }
-
-        boolean isEmpty() {
-            return element == null;
-        }
     }
 
-
     private final int os;
     private int head;
     private final Node<T>[] cursorSpace;
     private int count;
     private final static int CURSOR_SPACE_SIZE = 100;
 
 
+    
     {
         // init at loading time
         cursorSpace = new Node[CURSOR_SPACE_SIZE];
diff --git a/DataStructures/Lists/SinglyLinkedList.java b/DataStructures/Lists/SinglyLinkedList.java
@@ -120,9 +120,9 @@ public void deleteNth(int position) {
             cur = cur.next;
         }
 
-        Node destroy = cur.next;
+        //Node destroy = cur.next;
         cur.next = cur.next.next;
-        destroy = null; // clear to let GC do its work
+        //destroy = null; // clear to let GC do its work
 
         size--;
     }
diff --git a/DataStructures/Trees/RedBlackBST.java b/DataStructures/Trees/RedBlackBST.java
@@ -330,5 +330,6 @@ public void deleteDemo() {
         printTree(root);
         System.out.println("Pre order");
         printTreepre(root);
+        scan.close();
     }
 }
diff --git a/MinimizingLateness/MinimizingLateness.java b/MinimizingLateness/MinimizingLateness.java
@@ -26,6 +26,7 @@ public static void main(String[] args) throws IOException {
         BufferedReader in = new BufferedReader(new FileReader("MinimizingLateness/lateness_data.txt"));
         String ch = in.readLine();
         if (ch == null || ch.isEmpty()) {
+            in.close();
             return;
         }
         int indexCount = Integer.parseInt(ch);
diff --git a/Misc/heap_sort.java b/Misc/heap_sort.java
@@ -57,8 +57,7 @@ static void printArray(int[] arr) {
     // Driver program
     public static void main(String args[]) {
         int arr[] = {12, 11, 13, 5, 6, 7};
-        int n = arr.length;
-
+        
         heap_sort ob = new heap_sort();
         ob.sort(arr);
 
diff --git a/Sorts/MergeSort.java b/Sorts/MergeSort.java
@@ -20,7 +20,7 @@ class MergeSort implements SortAlgorithm {
      * @return sorted array
      */
     @Override
-    @SuppressWarnings("unchecked")
+    
     public <T extends Comparable<T>> T[] sort(T[] unsorted) {
         doSort(unsorted, 0, unsorted.length - 1);
         return unsorted;

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ public static void conventionalConversion() {`
`35`	`35`	`n /= 2;`
`36`	`36`	`} //converting decimal to binary`
`37`	`37`	`System.out.println("\tBinary number: " + b);`
	`38`	`+ input.close();`
`38`	`39`	`}`
`39`	`40`
`40`	`41`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class Cycle {`
`10`	`10`	`private int[][] adjacencyMatrix;`
`11`	`11`	`private boolean[] visited;`
`12`	`12`	`ArrayList<ArrayList<Integer>> cycles = new ArrayList<ArrayList<Integer>>();`
`13`		`- private boolean[] finalCycles;`
	`13`	`+`
`14`	`14`
`15`	`15`	`public Cycle() {`
`16`	`16`	`Scanner in = new Scanner(System.in);`
`@@ -34,6 +34,7 @@ public Cycle() {`
`34`	`34`	`end = in.nextInt();`
`35`	`35`	`adjacencyMatrix[start][end] = 1;`
`36`	`36`	`}`
	`37`	`+ in.close();`
`37`	`38`
`38`	`39`	`}`
`39`	`40`
Original file line number	Diff line number	Diff line change
`@@ -8,16 +8,15 @@ public static void main(String[] args) {`
`8`	`8`	`int choice, key;`
`9`	`9`
`10`	`10`	`HashMap h = new HashMap(7);`
	`11`	`+ Scanner In = new Scanner(System.in);`
`11`	`12`
`12`	`13`	`while (true) {`
`13`	`14`	`System.out.println("Enter your Choice :");`
`14`	`15`	`System.out.println("1. Add Key");`
`15`	`16`	`System.out.println("2. Delete Key");`
`16`	`17`	`System.out.println("3. Print Table");`
`17`	`18`	`System.out.println("4. Exit");`
`18`		`-`
`19`		`- Scanner In = new Scanner(System.in);`
`20`		`-`
	`19`	`+`
`21`	`20`	`choice = In.nextInt();`
`22`	`21`
`23`	`22`	`switch (choice) {`
`@@ -39,10 +38,11 @@ public static void main(String[] args) {`
`39`	`38`	`break;`
`40`	`39`	`}`
`41`	`40`	`case 4: {`
	`41`	`+ In.close();`
`42`	`42`	`return;`
`43`	`43`	`}`
`44`	`44`	`}`
`45`		`- In.close();`
	`45`	`+`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -120,9 +120,9 @@ public void deleteNth(int position) {`
`120`	`120`	`cur = cur.next;`
`121`	`121`	`}`
`122`	`122`
`123`		`- Node destroy = cur.next;`
	`123`	`+ //Node destroy = cur.next;`
`124`	`124`	`cur.next = cur.next.next;`
`125`		`- destroy = null; // clear to let GC do its work`
	`125`	`+ //destroy = null; // clear to let GC do its work`
`126`	`126`
`127`	`127`	`size--;`
`128`	`128`	`}`