Merge pull request #447 from dnjsndnjs/stack

Christian Bender · web-flow · commit 4733a63f6088 · 2018-06-07T22:24:16.000+02:00
fix stack
diff --git a/DataStructures/Stacks/Stacks.java b/DataStructures/Stacks/Stacks.java
@@ -53,18 +53,16 @@ public void push(int value){
 	 * @return value popped off the Stack
 	 */
 	public int pop(){
-		if(!isEmpty()){ //Checks for an empty stack
-			return stackArray[top--];
+		if(isEmpty()){ //Checks for an empty stack
+			System.out.println("The stack is already empty");
+			return -1;
 		}
 
 		if(top < maxSize/4){
 			resize(maxSize/2);
-			return pop();// don't forget pop after resizing
-		}
-		else{
-			System.out.println("The stack is already empty");
-			return -1;
 		}
+        
+        return stackArray[top--];
 	}
 
 	/**
