Skip to content

Other/Dijkshtra.java has some problems. I would like to recommend it's removal. #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmakynen opened this issue Oct 8, 2018 · 3 comments
Closed

Other/Dijkshtra.java has some problems. I would like to recommend it's removal. #560

rmakynen opened this issue Oct 8, 2018 · 3 comments
Labels
stale

Comments

@rmakynen
Copy link
Contributor

rmakynen commented Oct 8, 2018

Other/Dijkshtra.java has some problems:

  • Hard-coded magic numbers (1000000l)
  • initialization of a very large 2-dimensional array when it is not needed when using another implementation. - No description was given on the input format the algorithm was expecting.
  • Poor commenting.
  • Name of the algorithm is wrong. Should be "Dijkstra"

I have created a new pull request #559 that has new code for the algorithm. It has none of the above mentioned problems from what I can tell.

If the previously mentioned pull gets accepted, then I would recommend that the old version "Dijkshtra.java" should be removed.
@vishnoitanuj vishnoitanuj mentioned this issue Oct 1, 2019
Closed
@prashantdoshi28
Copy link

Hey @vishnoitanuj , I have requested some changes, go through my review for those.

@stale
Copy link

stale bot commented Feb 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 13, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

Please reopen this issue once you add more information and updates here. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prashantdoshi28 @rmakynen