Skip to content

Generalize using generics. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KylerSmith opened this issue Jul 8, 2017 · 10 comments
Closed

Generalize using generics. #65

KylerSmith opened this issue Jul 8, 2017 · 10 comments

Comments

@KylerSmith
Copy link

Enhancement

Description

Many of the algorithms, namely sorting, searching and the data structures, are using primitive types for the implementation of the algorithms. This could be generalized to any comparable type using generics.

@varunu28
Copy link
Contributor

Thanks for pointing that out @KylerSmith . @AnupKumarPanwar I would like to work on this issue. Can you please assign it to me

@varunu28
Copy link
Contributor

Here is the linear search with generics #80
Would start working on others and would add more search and sort methods in future

@0oo0
Copy link

0oo0 commented Aug 13, 2017

Thanks.

@varunu28
Copy link
Contributor

Added generic binary search #82
Done with the searches. Would be adding generic sorts in future.
Once both search and sorts are done let us make sure that any further addition of algorithms is in its generic form

@varunu28
Copy link
Contributor

varunu28 commented Aug 19, 2017

Started with creating generic version for sort
Bubble Sort #83
Insertion Sort #85
QuickSort #87
MergeSort #87
SelectionSort #93

This was referenced Aug 20, 2017
@dynamitechetan
Copy link
Member

Can we close this issue?

@shubhamtewari
Copy link
Contributor

shubhamtewari commented Jul 9, 2018

hey guys, should i apply generics to Data Structures?

@varunu28
Copy link
Contributor

@shubhamtewari Can you please point out which data structures, in particular, you want to apply generics?

@shubhamtewari
Copy link
Contributor

shubhamtewari commented Jul 10, 2018 via email

@varunu28
Copy link
Contributor

Sure. Go ahead.
You can open a PR once you are done with the changes. Go for refactoring the code rather than starting with a blank slate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants