You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Fibonacci sequence is defined by following statement: F(n) = F(n-1) + F(n-2) with F(0) = 0 and F(1) = 1. For reference, please see The online encyclopedia of integer sequences as primary reference, leading to other references with more detailed description.
(Older) books sometimes omit the preceding 0, but this representation is deprecated.
Current status
fibMemo
When calling the function Fibonacci.fibMemo, the result of F(0) = 1. This is incorrect since F(0) = 0. Furthermore this leads to the following sequence for the first few integers: [1, 1, 1, 2, 3, 5, ...] for input=[0, 1, 2, 3, 4, 5, ...].
fibBotUp
When calling the function Fibonacci.fibBotUp, the program throws an exception when trying to get the value for F(0) from the map. Therefore F(0) is not supported by this implementation.
Task
Fix both implementation(s) to
a) Return correct values for F(x)
b) Do not throw exceptions
Acceptance criteria is met when both functions return [0, 1, 1, 2, 3, 5] for input=[0, 1, 2, 3, 4, 5].
The text was updated successfully, but these errors were encountered:
@ales-blaze I have already fixed the bug because I was really bored. See the attached PR.
Furthermore: This bugfix was not intended to include major restructures but I highly suggest restructuring this repo and updating the code in order to keep up some quality in an additional issue.
There are some poor implementations and, as this bug showed, there are no tests that validate the correctness of proposed work. The only validation mechanisms is console output which is kind of pre 2000...
Uh oh!
There was an error while loading. Please reload this page.
Summary
The Fibonacci sequence is defined by following statement:
F(n) = F(n-1) + F(n-2) with F(0) = 0 and F(1) = 1. For reference, please see The online encyclopedia of integer sequences as primary reference, leading to other references with more detailed description.
(Older) books sometimes omit the preceding 0, but this representation is deprecated.
Current status
fibMemo
When calling the function Fibonacci.fibMemo, the result of F(0) = 1. This is incorrect since F(0) = 0. Furthermore this leads to the following sequence for the first few integers: [1, 1, 1, 2, 3, 5, ...] for input=[0, 1, 2, 3, 4, 5, ...].
fibBotUp
When calling the function Fibonacci.fibBotUp, the program throws an exception when trying to get the value for F(0) from the map. Therefore F(0) is not supported by this implementation.
Task
Fix both implementation(s) to
a) Return correct values for F(x)
b) Do not throw exceptions
Acceptance criteria is met when both functions return [0, 1, 1, 2, 3, 5] for input=[0, 1, 2, 3, 4, 5].
The text was updated successfully, but these errors were encountered: