Skip to content

Create Problem12.java #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2020
Merged

Create Problem12.java #1487

merged 3 commits into from
Oct 6, 2020

Conversation

deadshotsb
Copy link
Member

Added solution for problem 12 of Project Euler

Describe your change:

Added solution for problem 12 of Project Euler

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@deadshotsb
Create Problem12.java
2f2e944 
Added solution for problem 12 of Project Euler
yansheng836
yansheng836 reviewed Oct 1, 2020
View reviewed changes
Copy link

@yansheng836 yansheng836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some format problem, may be you should see pull_request_template again.

@deadshotsb
Copy link
Member Author

@yansheng836 Thanks for reviewing my work, can you be more specific about the format problems, are you referring to the checklists in my PR or any particular code segment in my PR?

@realDuYuanChao
Copy link
Member

Can you rename class name Problem_12_Highly_Divisible_Triangular_Number to Problem12 ? . follow this file: https://github.com/TheAlgorithms/Java/blob/master/ProjectEuler/Problem01.java

@deadshotsb
Copy link
Member Author

@shellhub you can have a look now.

@realDuYuanChao
Copy link
Member

@shellhub you can have a look now.

I reformated code. Hope you don't mind.

@realDuYuanChao realDuYuanChao merged commit 56196c8 into TheAlgorithms:master Oct 6, 2020
@deadshotsb
Copy link
Member Author

@shellhub you can have a look now.

I reformated code. Hope you don't mind.

@shellhub completely fine by me, it is important to upgrade the standards of our PR if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yansheng836 yansheng836 yansheng836 left review comments

@realDuYuanChao realDuYuanChao realDuYuanChao approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deadshotsb @realDuYuanChao @yansheng836