Skip to content

Tim sort Algorithm | #2003 #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Apr 23, 2021
Merged

Tim sort Algorithm | #2003 #2110

merged 23 commits into from
Apr 23, 2021

Conversation

hemanth-kotagiri
Copy link
Contributor

  • Add an algorithm?

References

Tim Sort Algorithm Wikipedia

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

@hemanth-kotagiri hemanth-kotagiri changed the title Tim sort Algorithm Tim sort Algorithm | #2003 Feb 21, 2021
ayaankhan98
ayaankhan98 suggested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation according to Java docs standard.

@hemanth-kotagiri
Copy link
Contributor Author

Hey there, @ayaankhan98 . Got it. I will be on it. I've been a bit busy!

@hemanth-kotagiri
Copy link
Contributor Author

Hello, @ayaankhan98. Could you please review it now. I might have missed something! Lemme know!

ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Feb 27, 2021
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test function to verify the implementation

ayaankhan98
ayaankhan98 reviewed Mar 9, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Mar 9, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Mar 9, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Mar 10, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Mar 10, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Mar 10, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Mar 10, 2021
View reviewed changes
hemanth-kotagiri and others added 8 commits March 10, 2021 10:55
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
327aea0 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
e673418 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
f09cd0d 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
40dc8f8 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
324cb4e 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
e29cb48 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
dd8ad4b 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
d1660bf 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
ayaankhan98
ayaankhan98 reviewed Mar 10, 2021
View reviewed changes
@stale
Copy link

stale bot commented Apr 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2021
@stale stale bot removed the stale label Apr 21, 2021
@hemanth-kotagiri
Copy link
Contributor Author

Would you give this a review @ayaankhan98

ayaankhan98
ayaankhan98 reviewed Apr 22, 2021
View reviewed changes
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
ed665f1 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
ayaankhan98
ayaankhan98 reviewed Apr 23, 2021
View reviewed changes
@hemanth-kotagiri
Copy link
Contributor Author

I appreciate your patience all the way along. Thanks. Is there anything else? @ayaankhan98 .

ayaankhan98
ayaankhan98 reviewed Apr 23, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Apr 23, 2021
View reviewed changes
ayaankhan98
ayaankhan98 reviewed Apr 23, 2021
View reviewed changes
hemanth-kotagiri and others added 3 commits April 23, 2021 22:30
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
0e81e1d 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
d76e46d 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri @ayaankhan98
Update Sorts/TimSort.java
4d7862f 
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri
Copy link
Contributor Author

Everything LGTM. Any other suggestions @ayaankhan98?

ayaankhan98
ayaankhan98 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of the code is fine. Prettier and code formatter errors are due to broken CI

@ayaankhan98 ayaankhan98 merged commit 66adafb into TheAlgorithms:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hemanth-kotagiri @ayaankhan98