Skip to content

RGB-HSV conversion #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2021
Merged

RGB-HSV conversion #2175

merged 4 commits into from
Apr 24, 2021

Conversation

algobytewise
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algobytewise
Copy link
Contributor Author

For the failed prettier-check, see #2149

@algobytewise algobytewise mentioned this pull request Apr 15, 2021
Closed
yanglbme
yanglbme requested changes Apr 15, 2021
View reviewed changes
Copy link
Member

@yanglbme yanglbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add package Conversions; to the file

@algobytewise
Copy link
Contributor Author

I've added the line. Thanks for having a look.

ayaankhan98
ayaankhan98 approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayaankhan98 ayaankhan98 merged commit b95ba6c into TheAlgorithms:master Apr 24, 2021
@ayaankhan98 ayaankhan98 linked an issue Apr 24, 2021 that may be closed by this pull request
Waiting for reviews of contributions #2185
Closed
@algobytewise algobytewise deleted the HSV-RGB-conversion branch April 26, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme requested changes

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waiting for reviews of contributions
3 participants
@algobytewise @yanglbme @ayaankhan98