Skip to content

Added Armstrong number algorithm. #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2017
Merged

Added Armstrong number algorithm. #240

merged 4 commits into from
Oct 25, 2017

Conversation

manimanasamylavarapu
Copy link

fixes #96

varunu28
varunu28 suggested changes Oct 21, 2017
View reviewed changes
Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the package
  • Please provide a description for checkIfANumberIsAmstrongOrNot function
  • Provide a description for what actually is an Armstrong number at the top along with an exampel

moved the class from others papckage to default.
364e27b 
and implemeted the following review comments.
Remove the package
Please provide a description for checkIfANumberIsAmstrongOrNot function
Provide a description for what actually is an
Armstrong number at the top along with an example

fixes TheAlgorithms#96
@manimanasamylavarapu
Copy link
Author

manimanasamylavarapu commented Oct 21, 2017 •
edited
Loading

@varunu28
Implemented review comments:
new commit in same pull request:
364e27b

varunu28
varunu28 suggested changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the package call and keep the file in Others folder and not the root folder

@manimanasamylavarapu
Copy link
Author

@varunu28 removed package and moved to others

@varunu28
Copy link
Contributor

Thanks for the changes and the PR @manimanasamylavarapu

@varunu28 varunu28 merged commit a0fd638 into TheAlgorithms:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunu28 varunu28 varunu28 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more algorithms
2 participants
@manimanasamylavarapu @varunu28