From 20acbd3fbbbe01e402a20ddb8dd86dcb8b663caf Mon Sep 17 00:00:00 2001 From: Vivek Date: Tue, 15 Mar 2022 01:12:10 +0530 Subject: [PATCH 1/8] Adding assertj --- pom.xml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pom.xml b/pom.xml index 48f9e1cbbbc6..2cb75a03a552 100644 --- a/pom.xml +++ b/pom.xml @@ -7,10 +7,12 @@ Java 1.0-SNAPSHOT jar + UTF-8 17 17 + 3.22.0 @@ -31,6 +33,11 @@ junit-jupiter test + + org.assertj + assertj-core + ${assertj.version} + From 090a316a85c94a25182014b98f573f0b7751ff92 Mon Sep 17 00:00:00 2001 From: Vivek Date: Tue, 15 Mar 2022 01:12:33 +0530 Subject: [PATCH 2/8] Updating Armstrong logic --- .../com/thealgorithms/maths/Armstrong.java | 33 +++++++++++------- .../thealgorithms/maths/ArmstrongTest.java | 34 +++++++++++++++++++ 2 files changed, 55 insertions(+), 12 deletions(-) create mode 100644 src/test/java/com/thealgorithms/maths/ArmstrongTest.java diff --git a/src/main/java/com/thealgorithms/maths/Armstrong.java b/src/main/java/com/thealgorithms/maths/Armstrong.java index df65ba750b01..54a24aa9622b 100644 --- a/src/main/java/com/thealgorithms/maths/Armstrong.java +++ b/src/main/java/com/thealgorithms/maths/Armstrong.java @@ -4,18 +4,11 @@ * An Armstrong number is equal to the sum of the cubes of its digits. For * example, 370 is an Armstrong number because 3*3*3 + 7*7*7 + 0*0*0 = 370. An * Armstrong number is often called Narcissistic number. + * + * @author Aitor Fidalgo Sánchez, Vivek (crackCodeLogN) */ public class Armstrong { - public static void main(String[] args) { - assert (isArmStrong(0)); - assert (isArmStrong(1)); - assert (isArmStrong(153)); - assert (isArmStrong(1634)); - assert (isArmStrong(371)); - assert (!isArmStrong(200)); - } - /** * Checks whether a given number is an armstrong number or not. * @@ -23,7 +16,7 @@ public static void main(String[] args) { * @return {@code true} if given number is armstrong number, {@code false} * otherwise */ - private static boolean isArmStrong(int number) { + public boolean isArmStrongV1(int number) { int sum = 0; int temp = number; int numberOfDigits = 0; @@ -37,10 +30,26 @@ private static boolean isArmStrong(int number) { int remainder = number % 10; int power = 1; for (int i = 1; i <= numberOfDigits; power *= remainder, ++i) - ; + ; sum = sum + power; number /= 10; } return sum == temp; } -} + + /** + * Checks whether a number is Armstrong or not. + * + * @param number + * @return {@code true} if given number is armstrong number, {@code false} otherwise + */ + public boolean isArmStrongV2(long number) { + long sum = 0, number2 = number; + while (number2 > 0) { + long mod = number2 % 10; + sum += Math.pow(mod, 3); + number2 /= 10; + } + return sum == number; + } +} \ No newline at end of file diff --git a/src/test/java/com/thealgorithms/maths/ArmstrongTest.java b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java new file mode 100644 index 000000000000..c4961d8c895e --- /dev/null +++ b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java @@ -0,0 +1,34 @@ +package com.thealgorithms.maths; + +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * @author Vivek + * @since 15/03/22 + */ +class ArmstrongTest { + + Armstrong armstrong = new Armstrong(); + + @Test + void testIsArmStrongV1() { + assertThat(armstrong.isArmStrongV1(153)).isTrue(); + assertThat(armstrong.isArmStrongV1(0)).isTrue(); + assertThat(armstrong.isArmStrongV1(1)).isTrue(); + assertThat(armstrong.isArmStrongV1(1634)).isTrue(); + assertThat(armstrong.isArmStrongV1(371)).isTrue(); + assertThat(armstrong.isArmStrongV1(200)).isFalse(); + } + + @Test + void testIsArmStrongV2() { + assertThat(armstrong.isArmStrongV2(153)).isTrue(); + assertThat(armstrong.isArmStrongV2(0)).isTrue(); + assertThat(armstrong.isArmStrongV2(1)).isTrue(); + assertThat(armstrong.isArmStrongV2(1634)).isFalse(); //this proves wrong v1. + assertThat(armstrong.isArmStrongV2(371)).isTrue(); + assertThat(armstrong.isArmStrongV2(200)).isFalse(); + } +} \ No newline at end of file From 115946ab93fcd201260d2c3eb4b7dcddf9f41888 Mon Sep 17 00:00:00 2001 From: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Date: Mon, 14 Mar 2022 19:42:55 +0000 Subject: [PATCH 3/8] Update directory --- DIRECTORY.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/DIRECTORY.md b/DIRECTORY.md index b15e9e404dde..a70720ea20c8 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -8,6 +8,7 @@ * [IIRFilter](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/audiofilters/IIRFilter.java) * backtracking * [Combination](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/backtracking/Combination.java) + * [FloodFill](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/backtracking/FloodFill.java) * [KnightsTour](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/backtracking/KnightsTour.java) * [NQueens](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/backtracking/NQueens.java) * [Permutation](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/backtracking/Permutation.java) @@ -112,11 +113,13 @@ * [NextGraterElement](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/NextGraterElement.java) * [NextSmallerElement](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/NextSmallerElement.java) * [NodeStack](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/NodeStack.java) + * [PostfixToInfix](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/PostfixToInfix.java) * [ReverseStack](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/ReverseStack.java) * [StackArray](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/StackArray.java) * [StackArrayList](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/StackArrayList.java) * [StackOfLinkedList](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/StackOfLinkedList.java) * trees + * [AVLSimple](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/trees/AVLSimple.java) * [AVLTree](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/trees/AVLTree.java) * [BinaryTree](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/trees/BinaryTree.java) * [BSTIterative](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/trees/BSTIterative.java) @@ -165,7 +168,6 @@ * [EditDistance](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/EditDistance.java) * [EggDropping](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/EggDropping.java) * [Fibonacci](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/Fibonacci.java) - * [FloodFill](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/FloodFill.java) * [FordFulkerson](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/FordFulkerson.java) * [KadaneAlgorithm](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/KadaneAlgorithm.java) * [Knapsack](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/Knapsack.java) @@ -182,12 +184,14 @@ * [MemoizationTechniqueKnapsack](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/MemoizationTechniqueKnapsack.java) * [MinimumPathSum](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/MinimumPathSum.java) * [MinimumSumPartition](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/MinimumSumPartition.java) + * [NewManShanksPrime](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/NewManShanksPrime.java) * [PalindromicPartitioning](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/PalindromicPartitioning.java) * [RegexMatching](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/RegexMatching.java) * [RodCutting](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/RodCutting.java) * [ShortestCommonSupersequenceLength](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/ShortestCommonSupersequenceLength.java) * [SubsetSum](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/SubsetSum.java) * [Sum Of Subset](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/Sum_Of_Subset.java) + * [UniquePaths](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/UniquePaths.java) * [WineProblem](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/WineProblem.java) * maths * [AbsoluteMax](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/AbsoluteMax.java) @@ -217,6 +221,7 @@ * [FFTBluestein](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FFTBluestein.java) * [FibonacciJavaStreams](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FibonacciJavaStreams.java) * [FibonacciNumber](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FibonacciNumber.java) + * [FindKthNumber](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FindKthNumber.java) * [FindMax](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FindMax.java) * [FindMaxRecursion](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FindMaxRecursion.java) * [FindMin](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FindMin.java) @@ -409,8 +414,12 @@ * test * backtracking * [CombinationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/CombinationTest.java) + * [FloodFillTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/FloodFillTest.java) * [PermutationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/PermutationTest.java) * maths + * [ArmstrongTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/ArmstrongTest.java) + * [FFTTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/FFTTest.java) + * [GaussianTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/GaussianTest.java) * [KaprekarNumbersTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/KaprekarNumbersTest.java) * [PascalTriangleTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/PascalTriangleTest.java) * [PronicNumberTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/PronicNumberTest.java) @@ -421,7 +430,9 @@ * [FirstFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/FirstFitCPUTest.java) * [KadaneAlogrithmTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/KadaneAlogrithmTest.java) * [LinkList Sort test](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/LinkList_Sort_test.java) + * [NewManShanksPrimeTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/NewManShanksPrimeTest.java) * [NextFitTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/NextFitTest.java) + * [UniquePathsTests](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/UniquePathsTests.java) * [WorstFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/WorstFitCPUTest.java) * searches * [QuickSelectTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/searches/QuickSelectTest.java) From f255f84ae9b8d5302f72d0f95ae9f1d5e84f0d75 Mon Sep 17 00:00:00 2001 From: Vivek Date: Wed, 16 Mar 2022 00:50:19 +0530 Subject: [PATCH 4/8] Updating Armstrong logic --- .../com/thealgorithms/maths/Armstrong.java | 34 +++---------------- .../thealgorithms/maths/ArmstrongTest.java | 27 +++++---------- 2 files changed, 12 insertions(+), 49 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/Armstrong.java b/src/main/java/com/thealgorithms/maths/Armstrong.java index 54a24aa9622b..824a94dcfe01 100644 --- a/src/main/java/com/thealgorithms/maths/Armstrong.java +++ b/src/main/java/com/thealgorithms/maths/Armstrong.java @@ -5,7 +5,7 @@ * example, 370 is an Armstrong number because 3*3*3 + 7*7*7 + 0*0*0 = 370. An * Armstrong number is often called Narcissistic number. * - * @author Aitor Fidalgo Sánchez, Vivek (crackCodeLogN) + * @author Vivek */ public class Armstrong { @@ -16,35 +16,9 @@ public class Armstrong { * @return {@code true} if given number is armstrong number, {@code false} * otherwise */ - public boolean isArmStrongV1(int number) { - int sum = 0; - int temp = number; - int numberOfDigits = 0; - while (temp != 0) { - numberOfDigits++; - temp /= 10; - } - temp = number; - /* copy number again */ - while (number > 0) { - int remainder = number % 10; - int power = 1; - for (int i = 1; i <= numberOfDigits; power *= remainder, ++i) - ; - sum = sum + power; - number /= 10; - } - return sum == temp; - } - - /** - * Checks whether a number is Armstrong or not. - * - * @param number - * @return {@code true} if given number is armstrong number, {@code false} otherwise - */ - public boolean isArmStrongV2(long number) { - long sum = 0, number2 = number; + public boolean isArmStrong(int number) { + long sum = 0; + long number2 = number; while (number2 > 0) { long mod = number2 % 10; sum += Math.pow(mod, 3); diff --git a/src/test/java/com/thealgorithms/maths/ArmstrongTest.java b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java index c4961d8c895e..6f14943498c5 100644 --- a/src/test/java/com/thealgorithms/maths/ArmstrongTest.java +++ b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java @@ -10,25 +10,14 @@ */ class ArmstrongTest { - Armstrong armstrong = new Armstrong(); - - @Test - void testIsArmStrongV1() { - assertThat(armstrong.isArmStrongV1(153)).isTrue(); - assertThat(armstrong.isArmStrongV1(0)).isTrue(); - assertThat(armstrong.isArmStrongV1(1)).isTrue(); - assertThat(armstrong.isArmStrongV1(1634)).isTrue(); - assertThat(armstrong.isArmStrongV1(371)).isTrue(); - assertThat(armstrong.isArmStrongV1(200)).isFalse(); - } - @Test - void testIsArmStrongV2() { - assertThat(armstrong.isArmStrongV2(153)).isTrue(); - assertThat(armstrong.isArmStrongV2(0)).isTrue(); - assertThat(armstrong.isArmStrongV2(1)).isTrue(); - assertThat(armstrong.isArmStrongV2(1634)).isFalse(); //this proves wrong v1. - assertThat(armstrong.isArmStrongV2(371)).isTrue(); - assertThat(armstrong.isArmStrongV2(200)).isFalse(); + void testisArmStrong() { + Armstrong armstrong = new Armstrong(); + assertThat(armstrong.isArmStrong(153)).isTrue(); + assertThat(armstrong.isArmStrong(0)).isTrue(); + assertThat(armstrong.isArmStrong(1)).isTrue(); + assertThat(armstrong.isArmStrong(1634)).isFalse(); //this proves wrong v1. + assertThat(armstrong.isArmStrong(371)).isTrue(); + assertThat(armstrong.isArmStrong(200)).isFalse(); } } \ No newline at end of file From e47c70940394878bfbf64818fed7ab18e30a7e76 Mon Sep 17 00:00:00 2001 From: Vivek Date: Wed, 16 Mar 2022 00:53:33 +0530 Subject: [PATCH 5/8] Refactor --- src/test/java/com/thealgorithms/maths/ArmstrongTest.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/thealgorithms/maths/ArmstrongTest.java b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java index 6f14943498c5..b33336670ca9 100644 --- a/src/test/java/com/thealgorithms/maths/ArmstrongTest.java +++ b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java @@ -13,11 +13,12 @@ class ArmstrongTest { @Test void testisArmStrong() { Armstrong armstrong = new Armstrong(); - assertThat(armstrong.isArmStrong(153)).isTrue(); assertThat(armstrong.isArmStrong(0)).isTrue(); assertThat(armstrong.isArmStrong(1)).isTrue(); - assertThat(armstrong.isArmStrong(1634)).isFalse(); //this proves wrong v1. + assertThat(armstrong.isArmStrong(153)).isTrue(); assertThat(armstrong.isArmStrong(371)).isTrue(); + + assertThat(armstrong.isArmStrong(1634)).isFalse(); assertThat(armstrong.isArmStrong(200)).isFalse(); } } \ No newline at end of file From 919c4abb32052935e36d5a54dd507096f07688e7 Mon Sep 17 00:00:00 2001 From: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Date: Sun, 10 Apr 2022 14:04:07 +0000 Subject: [PATCH 6/8] Update directory --- DIRECTORY.md | 62 ++++++++++++++++++++++++++++------------------------ 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/DIRECTORY.md b/DIRECTORY.md index fd8dc1453d79..5b3ee19d0eee 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -94,7 +94,6 @@ * [MergeSortedArrayList](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/lists/MergeSortedArrayList.java) * [MergeSortedSinglyLinkedList](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/lists/MergeSortedSinglyLinkedList.java) * [RandomNode](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/lists/RandomNode.java) - * [RemoveDuplicateNodes](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/lists/RemoveDuplicateNodes.java) * [SearchSinglyLinkedListRecursion](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/lists/SearchSinglyLinkedListRecursion.java) * [SinglyLinkedList](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/lists/SinglyLinkedList.java) * queues @@ -109,6 +108,7 @@ * [DecimalToAnyUsingStack](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/DecimalToAnyUsingStack.java) * [DuplicateBrackets](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/DuplicateBrackets.java) * [InfixToPostfix](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/InfixToPostfix.java) + * [LargestRectangle](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/LargestRectangle.java) * [MaximumMinimumWindow](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/MaximumMinimumWindow.java) * [NextGraterElement](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/NextGraterElement.java) * [NextSmallerElement](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/stacks/NextSmallerElement.java) @@ -163,6 +163,7 @@ * [BruteForceKnapsack](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/BruteForceKnapsack.java) * [CatalanNumber](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/CatalanNumber.java) * [CoinChange](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/CoinChange.java) + * [CountFriendsPairing](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/CountFriendsPairing.java) * [DiceThrow](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/DiceThrow.java) * [DyanamicProgrammingKnapsack](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/DyanamicProgrammingKnapsack.java) * [EditDistance](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/EditDistance.java) @@ -412,30 +413,35 @@ * [Upper](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/strings/Upper.java) * [WordLadder](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/strings/WordLadder.java) * test - * backtracking - * [CombinationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/CombinationTest.java) - * [FloodFillTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/FloodFillTest.java) - * [PermutationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/PermutationTest.java) - * maths - * [ArmstrongTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/ArmstrongTest.java) - * [FFTTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/FFTTest.java) - * [GaussianTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/GaussianTest.java) - * [KaprekarNumbersTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/KaprekarNumbersTest.java) - * [PascalTriangleTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/PascalTriangleTest.java) - * [PronicNumberTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/PronicNumberTest.java) - * [SquareRootwithBabylonianMethodTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/SquareRootwithBabylonianMethodTest.java) - * others - * [ArrayLeftRotationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/ArrayLeftRotationTest.java) - * [BestFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/BestFitCPUTest.java) - * [FirstFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/FirstFitCPUTest.java) - * [KadaneAlogrithmTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/KadaneAlogrithmTest.java) - * [LinkList Sort test](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/LinkList_Sort_test.java) - * [NewManShanksPrimeTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/NewManShanksPrimeTest.java) - * [NextFitTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/NextFitTest.java) - * [UniquePathsTests](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/UniquePathsTests.java) - * [WorstFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/WorstFitCPUTest.java) - * searches - * [QuickSelectTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/searches/QuickSelectTest.java) - * strings - * [AlphabeticalTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/AlphabeticalTest.java) - * [PangramTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/PangramTest.java) + * backtracking + * [CombinationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/CombinationTest.java) + * [FloodFillTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/FloodFillTest.java) + * [PermutationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/backtracking/PermutationTest.java) + * maths + * [ArmstrongTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/ArmstrongTest.java) + * [FFTTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/FFTTest.java) + * [GaussianTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/GaussianTest.java) + * [KaprekarNumbersTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/KaprekarNumbersTest.java) + * [PascalTriangleTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/PascalTriangleTest.java) + * [PronicNumberTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/PronicNumberTest.java) + * [SquareRootwithBabylonianMethodTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/maths/SquareRootwithBabylonianMethodTest.java) + * others + * [ArrayLeftRotationTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/ArrayLeftRotationTest.java) + * [BestFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/BestFitCPUTest.java) + * [CountFriendsPairingTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/CountFriendsPairingTest.java) + * [FirstFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/FirstFitCPUTest.java) + * [KadaneAlogrithmTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/KadaneAlogrithmTest.java) + * [LinkList Sort test](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/LinkList_Sort_test.java) + * [NewManShanksPrimeTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/NewManShanksPrimeTest.java) + * [NextFitTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/NextFitTest.java) + * [UniquePathsTests](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/UniquePathsTests.java) + * [WorstFitCPUTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/others/WorstFitCPUTest.java) + * searches + * [QuickSelectTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/searches/QuickSelectTest.java) + * strings + * [AlphabeticalTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/AlphabeticalTest.java) + * [AnagramsTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/AnagramsTest.java) + * [CharacterSameTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/CharacterSameTest.java) + * [PalindromeTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/PalindromeTest.java) + * [PangramTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/PangramTest.java) + * [UpperTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/strings/UpperTest.java) From 66a877bfe06986863b94fa08641b9c5a292623c4 Mon Sep 17 00:00:00 2001 From: Andrii Siriak Date: Sun, 10 Apr 2022 17:05:21 +0300 Subject: [PATCH 7/8] Update src/test/java/com/thealgorithms/maths/ArmstrongTest.java --- .../com/thealgorithms/maths/ArmstrongTest.java | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/test/java/com/thealgorithms/maths/ArmstrongTest.java b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java index b33336670ca9..a833e41044f7 100644 --- a/src/test/java/com/thealgorithms/maths/ArmstrongTest.java +++ b/src/test/java/com/thealgorithms/maths/ArmstrongTest.java @@ -11,14 +11,13 @@ class ArmstrongTest { @Test - void testisArmStrong() { + void testIsArmstrong() { Armstrong armstrong = new Armstrong(); - assertThat(armstrong.isArmStrong(0)).isTrue(); - assertThat(armstrong.isArmStrong(1)).isTrue(); - assertThat(armstrong.isArmStrong(153)).isTrue(); - assertThat(armstrong.isArmStrong(371)).isTrue(); - - assertThat(armstrong.isArmStrong(1634)).isFalse(); - assertThat(armstrong.isArmStrong(200)).isFalse(); + assertThat(armstrong.isArmstrong(0)).isTrue(); + assertThat(armstrong.isArmstrong(1)).isTrue(); + assertThat(armstrong.isArmstrong(153)).isTrue(); + assertThat(armstrong.isArmstrong(371)).isTrue(); + assertThat(armstrong.isArmstrong(1634)).isFalse(); + assertThat(armstrong.isArmstrong(200)).isFalse(); } -} \ No newline at end of file +} From a148478c2b0bc07bb91587698a46967834b4fa2a Mon Sep 17 00:00:00 2001 From: Andrii Siriak Date: Sun, 10 Apr 2022 17:08:00 +0300 Subject: [PATCH 8/8] Update src/main/java/com/thealgorithms/maths/Armstrong.java --- src/main/java/com/thealgorithms/maths/Armstrong.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/thealgorithms/maths/Armstrong.java b/src/main/java/com/thealgorithms/maths/Armstrong.java index 824a94dcfe01..fa1198ceaea3 100644 --- a/src/main/java/com/thealgorithms/maths/Armstrong.java +++ b/src/main/java/com/thealgorithms/maths/Armstrong.java @@ -16,7 +16,7 @@ public class Armstrong { * @return {@code true} if given number is armstrong number, {@code false} * otherwise */ - public boolean isArmStrong(int number) { + public boolean isArmstrong(int number) { long sum = 0; long number2 = number; while (number2 > 0) {