From 6f2b92366efcf818942d20616b36a436a7b9579e Mon Sep 17 00:00:00 2001 From: Cristiano Jesus Date: Thu, 21 Apr 2022 00:18:38 +0100 Subject: [PATCH] feat: Code refactor for AbsoluteMax improvements I'm refactoring some classes from the `maths` package to have a cleaner, more concise, easier to maintain and better documented code. I've refactored the AbsoluteMax again because I realized it can be improved even further by replacing the `if` inside `forEach` with a `filter` in the Stream. Resolves: #3028 --- src/main/java/com/thealgorithms/maths/AbsoluteMax.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/AbsoluteMax.java b/src/main/java/com/thealgorithms/maths/AbsoluteMax.java index 76430db77195..0852fe85be7e 100644 --- a/src/main/java/com/thealgorithms/maths/AbsoluteMax.java +++ b/src/main/java/com/thealgorithms/maths/AbsoluteMax.java @@ -21,11 +21,8 @@ public static int getMaxValue(int... numbers) { Arrays.stream(numbers) .skip(1) - .forEach(number -> { - if (Math.abs(number) > Math.abs(absMaxWrapper.value)) { - absMaxWrapper.value = number; - } - }); + .filter(number -> Math.abs(number) > Math.abs(absMaxWrapper.value)) + .forEach(number -> absMaxWrapper.value = number); return absMaxWrapper.value; }