From 397e93008e783e65ce1412db9748c777535318b2 Mon Sep 17 00:00:00 2001 From: Taranjeet Singh Kalsi Date: Mon, 31 Oct 2022 20:02:18 +0530 Subject: [PATCH 1/4] Added function in PerfectNumber.java Added isPerfectNumber2() in PerfectNumber.java --- .../thealgorithms/maths/PerfectNumber.java | 44 ++++++++++++++----- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/PerfectNumber.java b/src/main/java/com/thealgorithms/maths/PerfectNumber.java index cd57000b7db3..1ee888dc4530 100644 --- a/src/main/java/com/thealgorithms/maths/PerfectNumber.java +++ b/src/main/java/com/thealgorithms/maths/PerfectNumber.java @@ -6,20 +6,10 @@ * has divisors 1, 2 and 3 (excluding itself), and 1 + 2 + 3 = 6, so 6 is a * perfect number. * - *

* link:https://en.wikipedia.org/wiki/Perfect_number */ public class PerfectNumber { - public static void main(String[] args) { - assert isPerfectNumber(6); - /* 1 + 2 + 3 == 6 */ - assert !isPerfectNumber(8); - /* 1 + 2 + 4 != 8 */ - assert isPerfectNumber(28); - /* 1 + 2 + 4 + 7 + 14 == 28 */ - } - /** * Check if {@code number} is perfect number or not * @@ -36,4 +26,38 @@ public static boolean isPerfectNumber(int number) { } return sum == number; } + + /** + * Check if {@code n} is perfect number or not + * + * @param n the number + * @return {@code true} if {@code number} is perfect number, otherwise false + */ + public static boolean isPerfectNumber2(int n) { + if (n <= 0) + return false; + int sum = 1; + double root = Math.sqrt(n); + + /* + * We can get the factors after the root by dividing number by its factors + * before the root. + * Ex- Factors of 100 are 1, 2, 4, 5, 10, 20, 25, 50 and 100. + * Root of 100 is 10. So factors before 10 are 1, 2, 4 and 5. + * Now by dividing 100 by each factor before 10 we get: + * 100/1 = 100, 100/2 = 50, 100/4 = 25 and 100/5 = 20 + * So we get 100, 50, 25 and 20 which are factors of 100 after 10 + */ + for (int i = 2; i <= root; i++) { + if (n % i == 0) { + sum += i + n / i; + } + } + + // if n is a perfect square then its root was added twice in above loop, so subtracting root from sum + if (root == (int) root) + sum -= root; + + return sum == n; + } } From 2f6653c9e6f1088b151385c3664d99393bbc4141 Mon Sep 17 00:00:00 2001 From: Taranjeet Singh Kalsi Date: Mon, 31 Oct 2022 20:04:24 +0530 Subject: [PATCH 2/4] Created PerfectNumberTest.java --- .../maths/PerfectNumberTest.java | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 src/test/java/com/thealgorithms/maths/PerfectNumberTest.java diff --git a/src/test/java/com/thealgorithms/maths/PerfectNumberTest.java b/src/test/java/com/thealgorithms/maths/PerfectNumberTest.java new file mode 100644 index 000000000000..92512e99e730 --- /dev/null +++ b/src/test/java/com/thealgorithms/maths/PerfectNumberTest.java @@ -0,0 +1,21 @@ +package com.thealgorithms.maths; + +import static org.junit.jupiter.api.Assertions.*; +import org.junit.jupiter.api.Test; + +class PerfectNumberTest { + + @Test + public void perfectNumber() { + int trueTestCases[] = { 6, 28, 496, 8128, 33550336 }; + int falseTestCases[] = { -6, 0, 1, 9, 123 }; + for (Integer n : trueTestCases) { + assertTrue(PerfectNumber.isPerfectNumber(n)); + assertTrue(PerfectNumber.isPerfectNumber2(n)); + } + for (Integer n : falseTestCases) { + assertFalse(PerfectNumber.isPerfectNumber(n)); + assertFalse(PerfectNumber.isPerfectNumber2(n)); + } + } +} From 6c47bdd1911aeeb45bc387d0a6ca9563e21c9353 Mon Sep 17 00:00:00 2001 From: Taranjeet Singh Kalsi Date: Mon, 31 Oct 2022 20:20:31 +0530 Subject: [PATCH 3/4] fixed isPerfectNumber() fixed bug in isPerfectNumber() for negative numbers --- src/main/java/com/thealgorithms/maths/PerfectNumber.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/com/thealgorithms/maths/PerfectNumber.java b/src/main/java/com/thealgorithms/maths/PerfectNumber.java index 1ee888dc4530..d0d7cd0a3cd3 100644 --- a/src/main/java/com/thealgorithms/maths/PerfectNumber.java +++ b/src/main/java/com/thealgorithms/maths/PerfectNumber.java @@ -17,6 +17,8 @@ public class PerfectNumber { * @return {@code true} if {@code number} is perfect number, otherwise false */ public static boolean isPerfectNumber(int number) { + if (n <= 0) + return false; int sum = 0; /* sum of its positive divisors */ for (int i = 1; i < number; ++i) { From 36ac575fe58528c8e6d3ef379e83a2420b194799 Mon Sep 17 00:00:00 2001 From: Taranjeet Singh Kalsi Date: Mon, 31 Oct 2022 20:23:07 +0530 Subject: [PATCH 4/4] fixed typo --- src/main/java/com/thealgorithms/maths/PerfectNumber.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/thealgorithms/maths/PerfectNumber.java b/src/main/java/com/thealgorithms/maths/PerfectNumber.java index d0d7cd0a3cd3..896b8cef8d21 100644 --- a/src/main/java/com/thealgorithms/maths/PerfectNumber.java +++ b/src/main/java/com/thealgorithms/maths/PerfectNumber.java @@ -17,7 +17,7 @@ public class PerfectNumber { * @return {@code true} if {@code number} is perfect number, otherwise false */ public static boolean isPerfectNumber(int number) { - if (n <= 0) + if (number <= 0) return false; int sum = 0; /* sum of its positive divisors */