From 439871b8a05a5bfbb58d27d007c8a2370dc92a87 Mon Sep 17 00:00:00 2001 From: HManiac74 Date: Sat, 22 Jul 2023 11:22:02 +0200 Subject: [PATCH 1/4] Code cleanup Removed unused imports --- .../java/com/thealgorithms/conversions/OctalToBinary.java | 1 - .../datastructures/graphs/TarjansAlgorithm.java | 1 - .../dynamicprogramming/LongestValidParentheses.java | 2 -- src/main/java/com/thealgorithms/maths/DudeneyNumber.java | 2 -- .../maths/SquareRootWithNewtonRaphsonMethod.java | 2 -- src/main/java/com/thealgorithms/others/CountWords.java | 2 -- .../java/com/thealgorithms/others/cn/HammingDistance.java | 3 --- .../searches/SearchInARowAndColWiseSortedMatrix.java | 2 -- .../searches/sortOrderAgnosticBinarySearch.java | 1 - src/main/java/com/thealgorithms/strings/WordLadder.java | 1 - .../datastructures/hashmap/hashing/MajorityElementTest.java | 1 - src/test/java/com/thealgorithms/io/BufferedReaderTest.java | 2 -- .../com/thealgorithms/others/cn/HammingDistanceTest.java | 2 -- .../com/thealgorithms/searches/BinarySearch2dArrayTest.java | 1 - .../searches/OrderAgnosticBinarySearchTest.java | 2 -- .../java/com/thealgorithms/sorts/MergeSortRecursiveTest.java | 1 - .../java/com/thealgorithms/sorts/SortingAlgorithmTest.java | 2 -- src/test/java/com/thealgorithms/sorts/TimSortTest.java | 5 ----- src/test/java/com/thealgorithms/strings/IsomorphicTest.java | 1 - 19 files changed, 34 deletions(-) diff --git a/src/main/java/com/thealgorithms/conversions/OctalToBinary.java b/src/main/java/com/thealgorithms/conversions/OctalToBinary.java index 711381d82a8e..4dd581bd6116 100644 --- a/src/main/java/com/thealgorithms/conversions/OctalToBinary.java +++ b/src/main/java/com/thealgorithms/conversions/OctalToBinary.java @@ -1,5 +1,4 @@ package com.thealgorithms.conversions; -import java.util.Scanner; /** * Converts any Octal Number to a Binary Number diff --git a/src/main/java/com/thealgorithms/datastructures/graphs/TarjansAlgorithm.java b/src/main/java/com/thealgorithms/datastructures/graphs/TarjansAlgorithm.java index 4390a2f14d3b..293ea5837823 100644 --- a/src/main/java/com/thealgorithms/datastructures/graphs/TarjansAlgorithm.java +++ b/src/main/java/com/thealgorithms/datastructures/graphs/TarjansAlgorithm.java @@ -1,7 +1,6 @@ package com.thealgorithms.datastructures.graphs; import java.util.ArrayList; -import java.util.Iterator; import java.util.List; import java.util.Stack; diff --git a/src/main/java/com/thealgorithms/dynamicprogramming/LongestValidParentheses.java b/src/main/java/com/thealgorithms/dynamicprogramming/LongestValidParentheses.java index f8de2d848294..5ceb85c984ca 100644 --- a/src/main/java/com/thealgorithms/dynamicprogramming/LongestValidParentheses.java +++ b/src/main/java/com/thealgorithms/dynamicprogramming/LongestValidParentheses.java @@ -1,7 +1,5 @@ package com.thealgorithms.dynamicprogramming; -import java.util.Scanner; - /** * Given a string containing just the characters '(' and ')', find the length of * the longest valid (well-formed) parentheses substring. diff --git a/src/main/java/com/thealgorithms/maths/DudeneyNumber.java b/src/main/java/com/thealgorithms/maths/DudeneyNumber.java index 72c2065e2121..69231af7bb85 100644 --- a/src/main/java/com/thealgorithms/maths/DudeneyNumber.java +++ b/src/main/java/com/thealgorithms/maths/DudeneyNumber.java @@ -6,8 +6,6 @@ */ package com.thealgorithms.maths; -import java.io.*; - public class DudeneyNumber { // returns True if the number is a Dudeney number and False if it is not a Dudeney number. diff --git a/src/main/java/com/thealgorithms/maths/SquareRootWithNewtonRaphsonMethod.java b/src/main/java/com/thealgorithms/maths/SquareRootWithNewtonRaphsonMethod.java index bd3e41134371..eb116d21ac36 100644 --- a/src/main/java/com/thealgorithms/maths/SquareRootWithNewtonRaphsonMethod.java +++ b/src/main/java/com/thealgorithms/maths/SquareRootWithNewtonRaphsonMethod.java @@ -1,7 +1,5 @@ package com.thealgorithms.maths; -import java.util.Scanner; - /* *To learn about the method, visit the link below : * https://en.wikipedia.org/wiki/Newton%27s_method diff --git a/src/main/java/com/thealgorithms/others/CountWords.java b/src/main/java/com/thealgorithms/others/CountWords.java index 5117b83b7e57..1defde2cdd8b 100644 --- a/src/main/java/com/thealgorithms/others/CountWords.java +++ b/src/main/java/com/thealgorithms/others/CountWords.java @@ -1,7 +1,5 @@ package com.thealgorithms.others; -import java.util.Scanner; - /** * @author Marcus */ diff --git a/src/main/java/com/thealgorithms/others/cn/HammingDistance.java b/src/main/java/com/thealgorithms/others/cn/HammingDistance.java index 38bfc0a566dc..820917a17229 100644 --- a/src/main/java/com/thealgorithms/others/cn/HammingDistance.java +++ b/src/main/java/com/thealgorithms/others/cn/HammingDistance.java @@ -1,8 +1,5 @@ package com.thealgorithms.others.cn; -import java.util.ArrayList; -import java.util.List; - final public class HammingDistance { private HammingDistance() { } diff --git a/src/main/java/com/thealgorithms/searches/SearchInARowAndColWiseSortedMatrix.java b/src/main/java/com/thealgorithms/searches/SearchInARowAndColWiseSortedMatrix.java index b173f66598fb..2bdcdb48b653 100644 --- a/src/main/java/com/thealgorithms/searches/SearchInARowAndColWiseSortedMatrix.java +++ b/src/main/java/com/thealgorithms/searches/SearchInARowAndColWiseSortedMatrix.java @@ -1,7 +1,5 @@ package com.thealgorithms.searches; -import java.util.Arrays; - public class SearchInARowAndColWiseSortedMatrix { /** * Search a key in row and column wise sorted matrix diff --git a/src/main/java/com/thealgorithms/searches/sortOrderAgnosticBinarySearch.java b/src/main/java/com/thealgorithms/searches/sortOrderAgnosticBinarySearch.java index 307aa957ec35..817d9b355450 100644 --- a/src/main/java/com/thealgorithms/searches/sortOrderAgnosticBinarySearch.java +++ b/src/main/java/com/thealgorithms/searches/sortOrderAgnosticBinarySearch.java @@ -1,5 +1,4 @@ package com.thealgorithms.searches; -import java.util.*; public class sortOrderAgnosticBinarySearch { public static int find(int[] arr, int key) { int start = 0; diff --git a/src/main/java/com/thealgorithms/strings/WordLadder.java b/src/main/java/com/thealgorithms/strings/WordLadder.java index edeb7036a24d..a4634ce01ee0 100644 --- a/src/main/java/com/thealgorithms/strings/WordLadder.java +++ b/src/main/java/com/thealgorithms/strings/WordLadder.java @@ -1,6 +1,5 @@ package com.thealgorithms.strings; -import java.util.Arrays; import java.util.HashSet; import java.util.LinkedList; import java.util.List; diff --git a/src/test/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElementTest.java b/src/test/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElementTest.java index 7f7c36011115..df014510e8cd 100644 --- a/src/test/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElementTest.java +++ b/src/test/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElementTest.java @@ -2,7 +2,6 @@ import static org.junit.jupiter.api.Assertions.*; -import com.thealgorithms.datastructures.hashmap.hashing.MajorityElement; import java.util.ArrayList; import java.util.Collections; import java.util.List; diff --git a/src/test/java/com/thealgorithms/io/BufferedReaderTest.java b/src/test/java/com/thealgorithms/io/BufferedReaderTest.java index 5d4c0f84bffd..c9872980c3b7 100644 --- a/src/test/java/com/thealgorithms/io/BufferedReaderTest.java +++ b/src/test/java/com/thealgorithms/io/BufferedReaderTest.java @@ -3,9 +3,7 @@ import static org.junit.jupiter.api.Assertions.*; import java.io.ByteArrayInputStream; -import java.io.ByteArrayOutputStream; import java.io.IOException; -import java.util.*; import org.junit.jupiter.api.Test; class BufferedReaderTest { diff --git a/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java b/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java index 4713af072f97..085cb431978c 100644 --- a/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java +++ b/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java @@ -1,8 +1,6 @@ package com.thealgorithms.others.cn; import org.assertj.core.api.Assertions; -import org.assertj.core.api.ThrowableTypeAssert; -import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; public class HammingDistanceTest { diff --git a/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java b/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java index 8c9bf5ff86cc..75dda16fa70f 100644 --- a/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java +++ b/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java @@ -4,7 +4,6 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import java.util.*; -import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.Test; public class BinarySearch2dArrayTest { diff --git a/src/test/java/com/thealgorithms/searches/OrderAgnosticBinarySearchTest.java b/src/test/java/com/thealgorithms/searches/OrderAgnosticBinarySearchTest.java index afcbc52fdaca..c19adaa1260c 100644 --- a/src/test/java/com/thealgorithms/searches/OrderAgnosticBinarySearchTest.java +++ b/src/test/java/com/thealgorithms/searches/OrderAgnosticBinarySearchTest.java @@ -2,8 +2,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -import com.thealgorithms.searches.OrderAgnosticBinarySearch; -import java.util.*; import org.junit.jupiter.api.Test; public class OrderAgnosticBinarySearchTest { diff --git a/src/test/java/com/thealgorithms/sorts/MergeSortRecursiveTest.java b/src/test/java/com/thealgorithms/sorts/MergeSortRecursiveTest.java index bdc1017ea516..0e7874584c3f 100644 --- a/src/test/java/com/thealgorithms/sorts/MergeSortRecursiveTest.java +++ b/src/test/java/com/thealgorithms/sorts/MergeSortRecursiveTest.java @@ -2,7 +2,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -import java.util.ArrayList; import java.util.Arrays; import java.util.List; import org.junit.jupiter.api.Test; diff --git a/src/test/java/com/thealgorithms/sorts/SortingAlgorithmTest.java b/src/test/java/com/thealgorithms/sorts/SortingAlgorithmTest.java index ac11b8adfbdf..92e743cf220c 100644 --- a/src/test/java/com/thealgorithms/sorts/SortingAlgorithmTest.java +++ b/src/test/java/com/thealgorithms/sorts/SortingAlgorithmTest.java @@ -3,9 +3,7 @@ import static org.junit.jupiter.api.Assertions.*; import java.util.ArrayList; -import java.util.Arrays; import java.util.List; -import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; public abstract class SortingAlgorithmTest { diff --git a/src/test/java/com/thealgorithms/sorts/TimSortTest.java b/src/test/java/com/thealgorithms/sorts/TimSortTest.java index 564afe379ac5..38e29d6eadd3 100644 --- a/src/test/java/com/thealgorithms/sorts/TimSortTest.java +++ b/src/test/java/com/thealgorithms/sorts/TimSortTest.java @@ -1,10 +1,5 @@ package com.thealgorithms.sorts; -import static org.junit.jupiter.api.Assertions.*; - -import org.junit.jupiter.api.BeforeEach; -import org.junit.jupiter.api.Test; - class TimSortTest extends SortingAlgorithmTest { @Override SortAlgorithm getSortAlgorithm() { diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 991b0cf51ee8..2ec6f6e7620f 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -2,7 +2,6 @@ import static org.junit.jupiter.api.Assertions.*; -import java.util.*; import org.junit.jupiter.api.Test; public class IsomorphicTest { From 82c0505ee79aed96a34af6a79759f38bccb313a7 Mon Sep 17 00:00:00 2001 From: HManiac74 Date: Sat, 22 Jul 2023 11:30:27 +0200 Subject: [PATCH 2/4] Code cleanup Closed leaks. Scanner was not closed --- .../com/thealgorithms/datastructures/trees/nearestRightKey.java | 1 + src/main/java/com/thealgorithms/maths/DeterminantOfMatrix.java | 1 + src/main/java/com/thealgorithms/maths/KeithNumber.java | 1 + src/main/java/com/thealgorithms/maths/LeastCommonMultiple.java | 1 + src/main/java/com/thealgorithms/maths/MagicSquare.java | 1 + src/main/java/com/thealgorithms/maths/NonRepeatingElement.java | 1 + src/main/java/com/thealgorithms/misc/Sort012D.java | 1 + src/main/java/com/thealgorithms/misc/Sparcity.java | 1 + src/main/java/com/thealgorithms/misc/ThreeSumProblem.java | 1 + src/main/java/com/thealgorithms/others/BoyerMoore.java | 1 + src/main/java/com/thealgorithms/others/HappyNumbersSeq.java | 1 + src/main/java/com/thealgorithms/others/Huffman.java | 1 + src/main/java/com/thealgorithms/searches/LinearSearchThread.java | 1 + .../java/com/thealgorithms/searches/SquareRootBinarySearch.java | 1 + src/main/java/com/thealgorithms/sorts/MergeSortNoExtraSpace.java | 1 + .../com/thealgorithms/strings/LongestPalindromicSubstring.java | 1 + 16 files changed, 16 insertions(+) diff --git a/src/main/java/com/thealgorithms/datastructures/trees/nearestRightKey.java b/src/main/java/com/thealgorithms/datastructures/trees/nearestRightKey.java index f0626c1dae47..913ccda3828c 100644 --- a/src/main/java/com/thealgorithms/datastructures/trees/nearestRightKey.java +++ b/src/main/java/com/thealgorithms/datastructures/trees/nearestRightKey.java @@ -12,6 +12,7 @@ public static void main(String[] args) { int inputX0 = sc.nextInt(); int toPrint = nearestRightKey(root, inputX0); System.out.println("Key: " + toPrint); + sc.close(); } public static NRKTree BuildTree() { diff --git a/src/main/java/com/thealgorithms/maths/DeterminantOfMatrix.java b/src/main/java/com/thealgorithms/maths/DeterminantOfMatrix.java index c1ef3fc09e1d..401bedbccdc0 100644 --- a/src/main/java/com/thealgorithms/maths/DeterminantOfMatrix.java +++ b/src/main/java/com/thealgorithms/maths/DeterminantOfMatrix.java @@ -51,5 +51,6 @@ public static void main(String[] args) { } } System.out.println(determinant(a, n)); + in.close(); } } diff --git a/src/main/java/com/thealgorithms/maths/KeithNumber.java b/src/main/java/com/thealgorithms/maths/KeithNumber.java index 0ea68d50f7f3..1db9f9500ed1 100644 --- a/src/main/java/com/thealgorithms/maths/KeithNumber.java +++ b/src/main/java/com/thealgorithms/maths/KeithNumber.java @@ -49,5 +49,6 @@ public static void main(String[] args) { } else { System.out.println("No, the given number is not a Keith number."); } + in.close(); } } diff --git a/src/main/java/com/thealgorithms/maths/LeastCommonMultiple.java b/src/main/java/com/thealgorithms/maths/LeastCommonMultiple.java index 5c904c2d72f4..f4f7c94aa3e2 100644 --- a/src/main/java/com/thealgorithms/maths/LeastCommonMultiple.java +++ b/src/main/java/com/thealgorithms/maths/LeastCommonMultiple.java @@ -21,6 +21,7 @@ public static void main(String[] args) { System.out.println("Please enter second number >> "); int num2 = input.nextInt(); System.out.println("The least common multiple of two numbers is >> " + lcm(num1, num2)); + input.close(); } /* diff --git a/src/main/java/com/thealgorithms/maths/MagicSquare.java b/src/main/java/com/thealgorithms/maths/MagicSquare.java index e48efabe45fd..3bcede960346 100644 --- a/src/main/java/com/thealgorithms/maths/MagicSquare.java +++ b/src/main/java/com/thealgorithms/maths/MagicSquare.java @@ -45,5 +45,6 @@ public static void main(String[] args) { } System.out.println(); } + sc.close(); } } diff --git a/src/main/java/com/thealgorithms/maths/NonRepeatingElement.java b/src/main/java/com/thealgorithms/maths/NonRepeatingElement.java index 5db4a1a174e5..86dce42f1564 100644 --- a/src/main/java/com/thealgorithms/maths/NonRepeatingElement.java +++ b/src/main/java/com/thealgorithms/maths/NonRepeatingElement.java @@ -50,6 +50,7 @@ public static void main(String[] args) { } System.out.println("The two non repeating elements are " + num1 + " and " + num2); + sc.close(); } /* Explanation of the code: diff --git a/src/main/java/com/thealgorithms/misc/Sort012D.java b/src/main/java/com/thealgorithms/misc/Sort012D.java index 1337e5ca97a2..2ffe31b9ddd8 100644 --- a/src/main/java/com/thealgorithms/misc/Sort012D.java +++ b/src/main/java/com/thealgorithms/misc/Sort012D.java @@ -21,6 +21,7 @@ public static void main(String[] args) { a[i] = np.nextInt(); } sort012(a); + np.close(); } public static void sort012(int[] a) { diff --git a/src/main/java/com/thealgorithms/misc/Sparcity.java b/src/main/java/com/thealgorithms/misc/Sparcity.java index 994f19195e7d..7eb5e5896308 100644 --- a/src/main/java/com/thealgorithms/misc/Sparcity.java +++ b/src/main/java/com/thealgorithms/misc/Sparcity.java @@ -49,5 +49,6 @@ public static void main(String[] args) { } } System.out.println("Sparcity of matrix is: " + sparcity(mat)); + in.close(); } } diff --git a/src/main/java/com/thealgorithms/misc/ThreeSumProblem.java b/src/main/java/com/thealgorithms/misc/ThreeSumProblem.java index fcd7a4320199..1b72996d022b 100644 --- a/src/main/java/com/thealgorithms/misc/ThreeSumProblem.java +++ b/src/main/java/com/thealgorithms/misc/ThreeSumProblem.java @@ -19,6 +19,7 @@ public static void main(String[] args) { System.out.println("Brute Force Approach\n" + (th.BruteForce(arr, ts)) + "\n"); System.out.println("Two Pointer Approach\n" + (th.TwoPointer(arr, ts)) + "\n"); System.out.println("Hashmap Approach\n" + (th.Hashmap(arr, ts))); + scan.close(); } public List> BruteForce(int[] nums, int target) { diff --git a/src/main/java/com/thealgorithms/others/BoyerMoore.java b/src/main/java/com/thealgorithms/others/BoyerMoore.java index f12e2cff8419..09235b521b44 100644 --- a/src/main/java/com/thealgorithms/others/BoyerMoore.java +++ b/src/main/java/com/thealgorithms/others/BoyerMoore.java @@ -44,5 +44,6 @@ public static void main(String[] args) { a[i] = input.nextInt(); } System.out.println("the majority element is " + findmajor(a)); + input.close(); } } diff --git a/src/main/java/com/thealgorithms/others/HappyNumbersSeq.java b/src/main/java/com/thealgorithms/others/HappyNumbersSeq.java index 050937879a1d..57ff204c39b1 100644 --- a/src/main/java/com/thealgorithms/others/HappyNumbersSeq.java +++ b/src/main/java/com/thealgorithms/others/HappyNumbersSeq.java @@ -19,6 +19,7 @@ public static void main(String[] args) { } String res = n == 1 ? "1 Happy number" : "Sad number"; System.out.println(res); + in.close(); } private static int sumSquares(int n) { diff --git a/src/main/java/com/thealgorithms/others/Huffman.java b/src/main/java/com/thealgorithms/others/Huffman.java index a5af2becc993..cc8c8d09864f 100644 --- a/src/main/java/com/thealgorithms/others/Huffman.java +++ b/src/main/java/com/thealgorithms/others/Huffman.java @@ -118,5 +118,6 @@ public static void main(String[] args) { // print the codes by traversing the tree printCode(root, ""); + s.close(); } } diff --git a/src/main/java/com/thealgorithms/searches/LinearSearchThread.java b/src/main/java/com/thealgorithms/searches/LinearSearchThread.java index c277b68f859b..6e9d73af6b1f 100644 --- a/src/main/java/com/thealgorithms/searches/LinearSearchThread.java +++ b/src/main/java/com/thealgorithms/searches/LinearSearchThread.java @@ -33,6 +33,7 @@ public static void main(String[] args) { } boolean found = t.getResult() || t1.getResult() || t2.getResult() || t3.getResult(); System.out.println("Found = " + found); + in.close(); } } diff --git a/src/main/java/com/thealgorithms/searches/SquareRootBinarySearch.java b/src/main/java/com/thealgorithms/searches/SquareRootBinarySearch.java index b8ee476bfcd9..afd5c194f7c4 100644 --- a/src/main/java/com/thealgorithms/searches/SquareRootBinarySearch.java +++ b/src/main/java/com/thealgorithms/searches/SquareRootBinarySearch.java @@ -27,6 +27,7 @@ public static void main(String[] args) { int num = sc.nextInt(); long ans = squareRoot(num); System.out.println("The square root is : " + ans); + sc.close(); } /** diff --git a/src/main/java/com/thealgorithms/sorts/MergeSortNoExtraSpace.java b/src/main/java/com/thealgorithms/sorts/MergeSortNoExtraSpace.java index 36b3f8dec98f..b9551523bb8d 100644 --- a/src/main/java/com/thealgorithms/sorts/MergeSortNoExtraSpace.java +++ b/src/main/java/com/thealgorithms/sorts/MergeSortNoExtraSpace.java @@ -66,5 +66,6 @@ public static void main(String[] args) { for (int i = 0; i < a.length; i++) { System.out.print(a[i] + " "); } + inp.close(); } } diff --git a/src/main/java/com/thealgorithms/strings/LongestPalindromicSubstring.java b/src/main/java/com/thealgorithms/strings/LongestPalindromicSubstring.java index 6efdabcec7f3..a74a10aa05c0 100644 --- a/src/main/java/com/thealgorithms/strings/LongestPalindromicSubstring.java +++ b/src/main/java/com/thealgorithms/strings/LongestPalindromicSubstring.java @@ -12,6 +12,7 @@ public static void main(String[] args) { System.out.print("Enter the string: "); str = sc.nextLine(); System.out.println("Longest substring is : " + s.longestPalindrome(str)); + sc.close(); } } From 338bfaf880662d287623189fae5d74e7714b59d2 Mon Sep 17 00:00:00 2001 From: HManiac74 Date: Sat, 22 Jul 2023 11:49:38 +0200 Subject: [PATCH 3/4] Code cleanup Removed unused variables and methods. --- .../lists/DoublyLinkedList.java | 7 ----- .../lists/Merge_K_SortedLinkedlist.java | 5 ---- .../lists/SinglyLinkedList.java | 7 ----- .../datastructures/stacks/NodeStack.java | 21 ++------------- .../datastructures/trees/GenericTree.java | 3 --- .../datastructures/trees/TreeRandomNode.java | 5 ---- .../MinimizingLateness.java | 5 ---- .../others/RotateMatriceBy90Degree.java | 3 +-- .../searches/PerfectBinarySearch.java | 5 ++-- .../thealgorithms/sorts/TopologicalSort.java | 26 ------------------- .../hashmap/HashMapCuckooHashingTest.java | 9 ------- .../thealgorithms/maths/FactorialTest.java | 3 +-- .../thealgorithms/maths/SumOfDigitsTest.java | 18 ++++++------- .../com/thealgorithms/others/CRC16Test.java | 2 +- .../others/cn/HammingDistanceTest.java | 6 ++--- .../searches/BinarySearch2dArrayTest.java | 7 ----- .../thealgorithms/sorts/OddEvenSortTest.java | 8 +++--- .../thealgorithms/strings/IsomorphicTest.java | 10 +++---- .../LetterCombinationsOfPhoneNumberTest.java | 11 ++++---- .../strings/ReverseStringRecursiveTest.java | 6 ++--- 20 files changed, 34 insertions(+), 133 deletions(-) diff --git a/src/main/java/com/thealgorithms/datastructures/lists/DoublyLinkedList.java b/src/main/java/com/thealgorithms/datastructures/lists/DoublyLinkedList.java index 1fa43328c61a..89117786c35e 100644 --- a/src/main/java/com/thealgorithms/datastructures/lists/DoublyLinkedList.java +++ b/src/main/java/com/thealgorithms/datastructures/lists/DoublyLinkedList.java @@ -28,18 +28,12 @@ public class DoublyLinkedList { */ private LinkOperations linkOperations; - /** - * Size refers to the number of elements present in the list - */ - private int size; - /** * Default Constructor */ public DoublyLinkedList() { head = null; tail = null; - size = 0; } /** @@ -55,7 +49,6 @@ public DoublyLinkedList(int[] array) { for (int i : array) { linkOperations.insertTail(i, this); } - size = array.length; } /** diff --git a/src/main/java/com/thealgorithms/datastructures/lists/Merge_K_SortedLinkedlist.java b/src/main/java/com/thealgorithms/datastructures/lists/Merge_K_SortedLinkedlist.java index 9d26645c2f9c..7206ccecf25e 100644 --- a/src/main/java/com/thealgorithms/datastructures/lists/Merge_K_SortedLinkedlist.java +++ b/src/main/java/com/thealgorithms/datastructures/lists/Merge_K_SortedLinkedlist.java @@ -47,10 +47,5 @@ private class Node { private int data; private Node next; - - public Node(int d) { - this.data = d; - next = null; - } } } diff --git a/src/main/java/com/thealgorithms/datastructures/lists/SinglyLinkedList.java b/src/main/java/com/thealgorithms/datastructures/lists/SinglyLinkedList.java index 8d15059367f1..68b0fd54c867 100644 --- a/src/main/java/com/thealgorithms/datastructures/lists/SinglyLinkedList.java +++ b/src/main/java/com/thealgorithms/datastructures/lists/SinglyLinkedList.java @@ -148,9 +148,7 @@ public Node reverseList(Node node) { public void clear() { Node cur = head; while (cur != null) { - Node prev = cur; cur = cur.next; - prev = null; // clear to let GC do its work } head = null; size = 0; @@ -346,9 +344,7 @@ public void delete() { public void deleteNth(int position) { checkBounds(position, 0, size - 1); if (position == 0) { - Node destroy = head; head = head.next; - destroy = null; /* clear to let GC do its work */ size--; return; @@ -358,10 +354,7 @@ public void deleteNth(int position) { cur = cur.next; } - Node destroy = cur.next; cur.next = cur.next.next; - destroy = null; // clear to let GC do its work - size--; } diff --git a/src/main/java/com/thealgorithms/datastructures/stacks/NodeStack.java b/src/main/java/com/thealgorithms/datastructures/stacks/NodeStack.java index ffdfc962224d..900d697f36f7 100644 --- a/src/main/java/com/thealgorithms/datastructures/stacks/NodeStack.java +++ b/src/main/java/com/thealgorithms/datastructures/stacks/NodeStack.java @@ -43,7 +43,6 @@ public static void main(String[] args) { private Item data; private static NodeStack head; - private NodeStack next; private NodeStack previous; private static int size = 0; @@ -72,7 +71,7 @@ public void push(Item item) { } else { newNs.setPrevious(NodeStack.head); NodeStack.head.setNext(newNs); - NodeStack.head.setHead(newNs); + NodeStack.setHead(newNs); } NodeStack.setSize(NodeStack.getSize() + 1); @@ -86,7 +85,7 @@ public void push(Item item) { public Item pop() { Item item = (Item) NodeStack.head.getData(); - NodeStack.head.setHead(NodeStack.head.getPrevious()); + NodeStack.setHead(NodeStack.head.getPrevious()); NodeStack.head.setNext(null); NodeStack.setSize(NodeStack.getSize() - 1); @@ -133,23 +132,11 @@ public void print() { } } - /** - * Getters and setters (private) - */ - private NodeStack getHead() { - return NodeStack.head; - } - private static void setHead(NodeStack ns) { NodeStack.head = ns; } - private NodeStack getNext() { - return next; - } - private void setNext(NodeStack next) { - this.next = next; } private NodeStack getPrevious() { @@ -171,8 +158,4 @@ private static void setSize(int size) { private Item getData() { return this.data; } - - private void setData(Item item) { - this.data = item; - } } diff --git a/src/main/java/com/thealgorithms/datastructures/trees/GenericTree.java b/src/main/java/com/thealgorithms/datastructures/trees/GenericTree.java index d4bbf0c9aad6..25347e2f8b1c 100644 --- a/src/main/java/com/thealgorithms/datastructures/trees/GenericTree.java +++ b/src/main/java/com/thealgorithms/datastructures/trees/GenericTree.java @@ -23,8 +23,6 @@ private class Node { } private Node root; - private int size; - public GenericTree() { // Constructor Scanner scn = new Scanner(System.in); root = create_treeG(null, 0, scn); @@ -44,7 +42,6 @@ private Node create_treeG(Node node, int childindx, Scanner scn) { int number = scn.nextInt(); for (int i = 0; i < number; i++) { Node child = create_treeG(node, i, scn); - size++; node.child.add(child); } return node; diff --git a/src/main/java/com/thealgorithms/datastructures/trees/TreeRandomNode.java b/src/main/java/com/thealgorithms/datastructures/trees/TreeRandomNode.java index d9f5a6f0ec43..eeb253d9d342 100644 --- a/src/main/java/com/thealgorithms/datastructures/trees/TreeRandomNode.java +++ b/src/main/java/com/thealgorithms/datastructures/trees/TreeRandomNode.java @@ -30,11 +30,6 @@ private class Node { int item; Node left, right; - - public Node(int key) { - item = key; - left = right = null; - } } // Using an arraylist to store the inorder traversal of the given binary tree diff --git a/src/main/java/com/thealgorithms/minimizinglateness/MinimizingLateness.java b/src/main/java/com/thealgorithms/minimizinglateness/MinimizingLateness.java index 4b30155b5275..fc7eae6ae9fc 100644 --- a/src/main/java/com/thealgorithms/minimizinglateness/MinimizingLateness.java +++ b/src/main/java/com/thealgorithms/minimizinglateness/MinimizingLateness.java @@ -11,9 +11,6 @@ private static class Schedule { // Schedule class int t = 0; // Time required for the operation to be performed int d = 0; // Time the job should be completed - int s = 0; // Start time of the task - int f = 0; // End time of the operation - public Schedule(int t, int d) { this.t = t; this.d = d; @@ -46,8 +43,6 @@ public static void main(String[] args) throws IOException { int tryTime = 0; // Total time worked int lateness = 0; // Lateness for (int j = 0; j < indexCount - 1; j++) { - array[j].s = tryTime; // Start time of the task - array[j].f = tryTime + array[j].t; // Time finished tryTime = tryTime + array[j].t; // Add total work time // Lateness lateness = lateness + Math.max(0, tryTime - array[j].d); diff --git a/src/main/java/com/thealgorithms/others/RotateMatriceBy90Degree.java b/src/main/java/com/thealgorithms/others/RotateMatriceBy90Degree.java index bc04616634bc..e2b47f8e627d 100644 --- a/src/main/java/com/thealgorithms/others/RotateMatriceBy90Degree.java +++ b/src/main/java/com/thealgorithms/others/RotateMatriceBy90Degree.java @@ -22,8 +22,7 @@ public static void main(String[] args) { } } - Rotate g = new Rotate(); - g.rotate(arr); + Rotate.rotate(arr); printMatrix(arr); } sc.close(); diff --git a/src/main/java/com/thealgorithms/searches/PerfectBinarySearch.java b/src/main/java/com/thealgorithms/searches/PerfectBinarySearch.java index 8ce01575b67d..bfeb5efc3a62 100644 --- a/src/main/java/com/thealgorithms/searches/PerfectBinarySearch.java +++ b/src/main/java/com/thealgorithms/searches/PerfectBinarySearch.java @@ -21,9 +21,8 @@ static int binarySearch(int[] arr, int target) { } public static void main(String[] args) { - PerfectBinarySearch BinarySearch = new PerfectBinarySearch(); int[] array = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10}; - assert BinarySearch.binarySearch(array, -1) == -1; - assert BinarySearch.binarySearch(array, 11) == -1; + assert PerfectBinarySearch.binarySearch(array, -1) == -1; + assert PerfectBinarySearch.binarySearch(array, 11) == -1; } } diff --git a/src/main/java/com/thealgorithms/sorts/TopologicalSort.java b/src/main/java/com/thealgorithms/sorts/TopologicalSort.java index 947e158a2a61..76d527ce756d 100644 --- a/src/main/java/com/thealgorithms/sorts/TopologicalSort.java +++ b/src/main/java/com/thealgorithms/sorts/TopologicalSort.java @@ -33,22 +33,6 @@ private static class Vertex { * */ public final String label; - /* - * Weight of vertex - * (more accurately defined as the time that a vertex has begun a visit in DFS) - * */ - public int weight; - - /* - * The time that the vertex has finished a visit in DFS - * */ - public int finished; - - /* - * π parent of the vertex - * */ - public Vertex predecessor; - /* * Represents the category of visit in DFS * */ @@ -90,11 +74,6 @@ public BackEdgeException(String backEdge) { } } - /* - * Time variable in DFS - * */ - private static int time; - /* * Depth First Search * @@ -135,12 +114,9 @@ public static LinkedList sort(Graph graph) { * u.f = time * */ private static String sort(Graph graph, Vertex u, LinkedList list) { - time++; - u.weight = time; u.color = Color.GRAY; graph.adj.get(u.label).next.forEach(label -> { if (graph.adj.get(label).color == Color.WHITE) { - graph.adj.get(label).predecessor = u; list.addFirst(sort(graph, graph.adj.get(label), list)); } else if (graph.adj.get(label).color == Color.GRAY) { /* @@ -153,8 +129,6 @@ private static String sort(Graph graph, Vertex u, LinkedList list) { } }); u.color = Color.BLACK; - time++; - u.finished = time; return u.label; } } diff --git a/src/test/java/com/thealgorithms/datastructures/hashmap/HashMapCuckooHashingTest.java b/src/test/java/com/thealgorithms/datastructures/hashmap/HashMapCuckooHashingTest.java index c7391c3af56f..851432006123 100644 --- a/src/test/java/com/thealgorithms/datastructures/hashmap/HashMapCuckooHashingTest.java +++ b/src/test/java/com/thealgorithms/datastructures/hashmap/HashMapCuckooHashingTest.java @@ -3,7 +3,6 @@ import static org.junit.jupiter.api.Assertions.*; import com.thealgorithms.datastructures.hashmap.hashing.HashMapCuckooHashing; -import java.util.*; import org.junit.jupiter.api.Test; class HashMapCuckooHashingTest { @@ -51,7 +50,6 @@ void removeKey() { @Test void removeNone() { HashMapCuckooHashing hashTable = new HashMapCuckooHashing(10); - int initialSize = hashTable.getNumberOfKeysInTable(); try { hashTable.deleteKeyFromHashTable(3); } catch (Exception e) { @@ -90,11 +88,4 @@ void avoidInfiniteLoops() { assertTrue(hashTable.checkTableContainsKey(10)); assertTrue(hashTable.checkTableContainsKey(100)); } - - private HashMapCuckooHashing createHashMapCuckooHashing() { - HashMapCuckooHashing hashTable = new HashMapCuckooHashing(10); - int[] values = {11, 22, 33, 44, 55, 66, 77, 88, 99, 111, 222}; - Arrays.stream(values).forEach(hashTable::insertKey2HashTable); - return hashTable; - } } diff --git a/src/test/java/com/thealgorithms/maths/FactorialTest.java b/src/test/java/com/thealgorithms/maths/FactorialTest.java index 18c58fad8280..752cd7a75cde 100644 --- a/src/test/java/com/thealgorithms/maths/FactorialTest.java +++ b/src/test/java/com/thealgorithms/maths/FactorialTest.java @@ -8,7 +8,6 @@ public class FactorialTest { @Test public void test() { - Factorial fact = new Factorial(); - assertEquals(120, fact.factorial(5)); + assertEquals(120, Factorial.factorial(5)); } } diff --git a/src/test/java/com/thealgorithms/maths/SumOfDigitsTest.java b/src/test/java/com/thealgorithms/maths/SumOfDigitsTest.java index 99c03cfae720..1c3b56b7ee5e 100644 --- a/src/test/java/com/thealgorithms/maths/SumOfDigitsTest.java +++ b/src/test/java/com/thealgorithms/maths/SumOfDigitsTest.java @@ -10,22 +10,22 @@ class SumOfDigitsTest { @Test void testZero() { - assertEquals(0, SoD.sumOfDigits(0)); - assertEquals(0, SoD.sumOfDigitsRecursion(0)); - assertEquals(0, SoD.sumOfDigitsFast(0)); + assertEquals(0, SumOfDigits.sumOfDigits(0)); + assertEquals(0, SumOfDigits.sumOfDigitsRecursion(0)); + assertEquals(0, SumOfDigits.sumOfDigitsFast(0)); } @Test void testPositive() { - assertEquals(15, SoD.sumOfDigits(12345)); - assertEquals(15, SoD.sumOfDigitsRecursion(12345)); - assertEquals(15, SoD.sumOfDigitsFast(12345)); + assertEquals(15, SumOfDigits.sumOfDigits(12345)); + assertEquals(15, SumOfDigits.sumOfDigitsRecursion(12345)); + assertEquals(15, SumOfDigits.sumOfDigitsFast(12345)); } @Test void testNegative() { - assertEquals(6, SoD.sumOfDigits(-123)); - assertEquals(6, SoD.sumOfDigitsRecursion(-123)); - assertEquals(6, SoD.sumOfDigitsFast(-123)); + assertEquals(6, SumOfDigits.sumOfDigits(-123)); + assertEquals(6, SumOfDigits.sumOfDigitsRecursion(-123)); + assertEquals(6, SumOfDigits.sumOfDigitsFast(-123)); } } diff --git a/src/test/java/com/thealgorithms/others/CRC16Test.java b/src/test/java/com/thealgorithms/others/CRC16Test.java index 513ec989291a..54e82f69aa88 100644 --- a/src/test/java/com/thealgorithms/others/CRC16Test.java +++ b/src/test/java/com/thealgorithms/others/CRC16Test.java @@ -14,7 +14,7 @@ void testCRC16() { String textToCRC16 = "hacktoberfest!"; // when - String resultCRC16 = crc.crc16(textToCRC16); // Algorithm CRC16-CCITT-FALSE + String resultCRC16 = CRC16.crc16(textToCRC16); // Algorithm CRC16-CCITT-FALSE // then assertEquals("10FC", resultCRC16); diff --git a/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java b/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java index 085cb431978c..982a04e09891 100644 --- a/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java +++ b/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java @@ -40,14 +40,14 @@ public void checkForLongDataBits() { @Test public void mismatchDataBits() { - Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { int answer = HammingDistance.compute("100010", "00011"); }); + Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { }); Assertions.assertThat(ex.getMessage()).contains("must have the same length"); } @Test public void mismatchDataBits2() { - Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { int answer = HammingDistance.compute("1", "11"); }); + Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { }); Assertions.assertThat(ex.getMessage()).contains("must have the same length"); } @@ -75,7 +75,7 @@ public void checkForInputOfLength1() { @Test public void computeThrowsExceptionWhenInputsAreNotBitStrs() { - Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { int answer = HammingDistance.compute("1A", "11"); }); + Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { }); Assertions.assertThat(ex.getMessage()).contains("must be a binary string"); } diff --git a/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java b/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java index 75dda16fa70f..e5db2f74f446 100644 --- a/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java +++ b/src/test/java/com/thealgorithms/searches/BinarySearch2dArrayTest.java @@ -15,7 +15,6 @@ public void BinarySearch2dArrayTestMiddle() { int target = 6; int[] ans = BinarySearch2dArray.BinarySearch(arr, target); - int[] expected = {1, 1}; System.out.println(Arrays.toString(ans)); assertEquals(1, ans[0]); assertEquals(1, ans[1]); @@ -28,7 +27,6 @@ public void BinarySearch2dArrayTestMiddleSide() { int target = 8; int[] ans = BinarySearch2dArray.BinarySearch(arr, target); - int[] expected = {1, 3}; System.out.println(Arrays.toString(ans)); assertEquals(1, ans[0]); assertEquals(3, ans[1]); @@ -41,7 +39,6 @@ public void BinarySearch2dArrayTestUpper() { int target = 2; int[] ans = BinarySearch2dArray.BinarySearch(arr, target); - int[] expected = {0, 1}; System.out.println(Arrays.toString(ans)); assertEquals(0, ans[0]); assertEquals(1, ans[1]); @@ -54,7 +51,6 @@ public void BinarySearch2dArrayTestUpperSide() { int target = 1; int[] ans = BinarySearch2dArray.BinarySearch(arr, target); - int[] expected = {0, 0}; System.out.println(Arrays.toString(ans)); assertEquals(0, ans[0]); assertEquals(0, ans[1]); @@ -67,7 +63,6 @@ public void BinarySearch2dArrayTestLower() { int target = 10; int[] ans = BinarySearch2dArray.BinarySearch(arr, target); - int[] expected = {2, 1}; System.out.println(Arrays.toString(ans)); assertEquals(2, ans[0]); assertEquals(1, ans[1]); @@ -80,7 +75,6 @@ public void BinarySearch2dArrayTestLowerSide() { int target = 11; int[] ans = BinarySearch2dArray.BinarySearch(arr, target); - int[] expected = {2, 2}; System.out.println(Arrays.toString(ans)); assertEquals(2, ans[0]); assertEquals(2, ans[1]); @@ -93,7 +87,6 @@ public void BinarySearch2dArrayTestNotFound() { int target = 101; int[] ans = BinarySearch2dArray.BinarySearch(arr, target); - int[] expected = {-1, -1}; System.out.println(Arrays.toString(ans)); assertEquals(-1, ans[0]); assertEquals(-1, ans[1]); diff --git a/src/test/java/com/thealgorithms/sorts/OddEvenSortTest.java b/src/test/java/com/thealgorithms/sorts/OddEvenSortTest.java index e6d86325e6c2..a7d0a58e229d 100644 --- a/src/test/java/com/thealgorithms/sorts/OddEvenSortTest.java +++ b/src/test/java/com/thealgorithms/sorts/OddEvenSortTest.java @@ -10,12 +10,10 @@ */ public class OddEvenSortTest { - private OddEvenSort oddEvenSort = new OddEvenSort(); - @Test public void oddEvenSortEmptyArray() { int[] inputArray = {}; - oddEvenSort.oddEvenSort(inputArray); + OddEvenSort.oddEvenSort(inputArray); int[] expectedOutput = {}; assertArrayEquals(inputArray, expectedOutput); } @@ -23,7 +21,7 @@ public void oddEvenSortEmptyArray() { @Test public void oddEvenSortNaturalNumberArray() { int[] inputArray = {18, 91, 86, 60, 21, 44, 37, 78, 98, 67}; - oddEvenSort.oddEvenSort(inputArray); + OddEvenSort.oddEvenSort(inputArray); int[] expectedOutput = {18, 21, 37, 44, 60, 67, 78, 86, 91, 98}; assertArrayEquals(inputArray, expectedOutput); } @@ -31,7 +29,7 @@ public void oddEvenSortNaturalNumberArray() { @Test public void oddEvenSortIntegerArray() { int[] inputArray = {57, 69, -45, 12, -85, 3, -76, 36, 67, -14}; - oddEvenSort.oddEvenSort(inputArray); + OddEvenSort.oddEvenSort(inputArray); int[] expectedOutput = {-85, -76, -45, -14, 3, 12, 36, 57, 67, 69}; assertArrayEquals(inputArray, expectedOutput); } diff --git a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java index 2ec6f6e7620f..a51b0fe9caa9 100644 --- a/src/test/java/com/thealgorithms/strings/IsomorphicTest.java +++ b/src/test/java/com/thealgorithms/strings/IsomorphicTest.java @@ -20,11 +20,9 @@ public static void main(String[] args) { String str7 = "aaammmnnn"; String str8 = "ggghhhbbj"; - Isomorphic isomorphic = new Isomorphic(); - - assertTrue(isomorphic.checkStrings(str1, str2)); - assertTrue(isomorphic.checkStrings(str3, str4)); - assertFalse(isomorphic.checkStrings(str5, str6)); - assertFalse(isomorphic.checkStrings(str7, str8)); + assertTrue(Isomorphic.checkStrings(str1, str2)); + assertTrue(Isomorphic.checkStrings(str3, str4)); + assertFalse(Isomorphic.checkStrings(str5, str6)); + assertFalse(Isomorphic.checkStrings(str7, str8)); } } diff --git a/src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java b/src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java index 5fc8541bd3d4..c9b890f4d502 100644 --- a/src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java +++ b/src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java @@ -9,29 +9,28 @@ public class LetterCombinationsOfPhoneNumberTest { @Test public void letterCombinationsOfPhoneNumber() { - LetterCombinationsOfPhoneNumber ob = new LetterCombinationsOfPhoneNumber(); - ob.generateNumberToCharMap(); + LetterCombinationsOfPhoneNumber.generateNumberToCharMap(); // ** Test 1 ** // Input: digits = "" // Output: [] int[] numbers1 = {}; List output1 = Arrays.asList(""); - assertTrue(ob.printWords(numbers1, numbers1.length, 0, "").equals(output1)); + assertTrue(LetterCombinationsOfPhoneNumber.printWords(numbers1, numbers1.length, 0, "").equals(output1)); // ** Test 2 ** // Input: digits = "2" // Output: ["a","b","c"] int[] numbers2 = {2}; List output2 = Arrays.asList("a", "b", "c"); - assertTrue(ob.printWords(numbers2, numbers2.length, 0, "").equals(output2)); + assertTrue(LetterCombinationsOfPhoneNumber.printWords(numbers2, numbers2.length, 0, "").equals(output2)); // ** Test 3 ** // Input: digits = "23" // Output: ["ad","ae","af","bd","be","bf","cd","ce","cf"] int[] numbers3 = {2, 3}; List output3 = Arrays.asList("ad", "ae", "af", "bd", "be", "bf", "cd", "ce", "cf"); - assertTrue(ob.printWords(numbers3, numbers3.length, 0, "").equals(output3)); + assertTrue(LetterCombinationsOfPhoneNumber.printWords(numbers3, numbers3.length, 0, "").equals(output3)); // ** Test 4 ** // Input: digits = "234" @@ -40,6 +39,6 @@ public void letterCombinationsOfPhoneNumber() { // "cdi", "ceg", "ceh", "cei", "cfg", "cfh", "cfi"] int[] numbers4 = {2, 3, 4}; List output4 = Arrays.asList("adg", "adh", "adi", "aeg", "aeh", "aei", "afg", "afh", "afi", "bdg", "bdh", "bdi", "beg", "beh", "bei", "bfg", "bfh", "bfi", "cdg", "cdh", "cdi", "ceg", "ceh", "cei", "cfg", "cfh", "cfi"); - assertTrue(ob.printWords(numbers4, numbers4.length, 0, "").equals(output4)); + assertTrue(LetterCombinationsOfPhoneNumber.printWords(numbers4, numbers4.length, 0, "").equals(output4)); } } diff --git a/src/test/java/com/thealgorithms/strings/ReverseStringRecursiveTest.java b/src/test/java/com/thealgorithms/strings/ReverseStringRecursiveTest.java index f36994be7cb8..af8d20ab9b7e 100644 --- a/src/test/java/com/thealgorithms/strings/ReverseStringRecursiveTest.java +++ b/src/test/java/com/thealgorithms/strings/ReverseStringRecursiveTest.java @@ -10,7 +10,7 @@ public class ReverseStringRecursiveTest { @Test void shouldAcceptWhenEmptyStringIsPassed() { String expected = ""; - String reversed = stringRecursive.reverse(""); + String reversed = ReverseStringRecursive.reverse(""); assertEquals(expected, reversed); } @@ -18,7 +18,7 @@ void shouldAcceptWhenEmptyStringIsPassed() { @Test void shouldAcceptNotWhenWhenSingleCharacterIsPassed() { String expected = "a"; - String reversed = stringRecursive.reverse("a"); + String reversed = ReverseStringRecursive.reverse("a"); assertEquals(expected, reversed); } @@ -26,7 +26,7 @@ void shouldAcceptNotWhenWhenSingleCharacterIsPassed() { @Test void shouldAcceptWhenStringIsPassed() { String expected = "dlroWolleH"; - String reversed = stringRecursive.reverse("HelloWorld"); + String reversed = ReverseStringRecursive.reverse("HelloWorld"); assertEquals(expected, reversed); } From 01b892224b169a73f0efdf0ec571725d618d5d27 Mon Sep 17 00:00:00 2001 From: HManiac74 Date: Sat, 22 Jul 2023 14:15:20 +0200 Subject: [PATCH 4/4] Update HammingDistanceTest.java Fix broken tests --- .../com/thealgorithms/others/cn/HammingDistanceTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java b/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java index 982a04e09891..669f928cd247 100644 --- a/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java +++ b/src/test/java/com/thealgorithms/others/cn/HammingDistanceTest.java @@ -40,14 +40,14 @@ public void checkForLongDataBits() { @Test public void mismatchDataBits() { - Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { }); + Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { HammingDistance.compute("100010", "00011"); }); Assertions.assertThat(ex.getMessage()).contains("must have the same length"); } @Test public void mismatchDataBits2() { - Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { }); + Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { HammingDistance.compute("1", "11"); }); Assertions.assertThat(ex.getMessage()).contains("must have the same length"); } @@ -75,7 +75,7 @@ public void checkForInputOfLength1() { @Test public void computeThrowsExceptionWhenInputsAreNotBitStrs() { - Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { }); + Exception ex = org.junit.jupiter.api.Assertions.assertThrows(IllegalArgumentException.class, () -> { HammingDistance.compute("1A", "11"); }); Assertions.assertThat(ex.getMessage()).contains("must be a binary string"); }