diff --git a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java index d19b80ab8d4c..103ff504ad14 100644 --- a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java +++ b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java @@ -1,6 +1,5 @@ package com.thealgorithms.maths; -import java.lang.IllegalArgumentException; import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; @@ -16,16 +15,16 @@ * - the base [2, 3, 5] ugly numbers are the same as base [5, 6, 2, 3, 5] ugly numbers */ public class NthUglyNumber { - ArrayList uglyNumbers = new ArrayList<>(Arrays.asList(1L)); - final int[] baseNumbers; - HashMap positions = new HashMap<>(); + private ArrayList uglyNumbers = new ArrayList<>(Arrays.asList(1L)); + private final int[] baseNumbers; + private HashMap positions = new HashMap<>(); /** * @brief initialized the object allowing to compute ugly numbers with given base * @param baseNumbers the given base of ugly numbers * @exception IllegalArgumentException baseNumber is empty */ - NthUglyNumber(int[] baseNumbers) { + NthUglyNumber(final int[] baseNumbers) { if (baseNumbers.length == 0) { throw new IllegalArgumentException("baseNumbers must be non-empty."); } @@ -41,7 +40,7 @@ public class NthUglyNumber { * @exception IllegalArgumentException n is negative * @return the n-th ugly number (starting from index 0) */ - public Long get(int n) { + public Long get(final int n) { if (n < 0) { throw new IllegalArgumentException("n must be non-negative."); } @@ -67,7 +66,7 @@ private void updatePositions() { } } - private long computeCandidate(int candidateBase) { + private long computeCandidate(final int candidateBase) { return candidateBase * uglyNumbers.get(positions.get(candidateBase)); }