From 1124924d1a7ac7caaae277d1fbf8959cb1a9cd43 Mon Sep 17 00:00:00 2001 From: Piotr Idzik Date: Sat, 22 Jul 2023 22:31:16 +0000 Subject: [PATCH 1/3] style: basic linting --- .../thealgorithms/maths/NthUglyNumber.java | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java index d19b80ab8d4c..52098fb8871d 100644 --- a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java +++ b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java @@ -1,6 +1,5 @@ package com.thealgorithms.maths; -import java.lang.IllegalArgumentException; import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; @@ -16,22 +15,22 @@ * - the base [2, 3, 5] ugly numbers are the same as base [5, 6, 2, 3, 5] ugly numbers */ public class NthUglyNumber { - ArrayList uglyNumbers = new ArrayList<>(Arrays.asList(1L)); - final int[] baseNumbers; - HashMap positions = new HashMap<>(); + private ArrayList uglyNumbers = new ArrayList<>(Arrays.asList(1L)); + private final int[] baseNumbers; + private HashMap positions = new HashMap<>(); /** * @brief initialized the object allowing to compute ugly numbers with given base * @param baseNumbers the given base of ugly numbers * @exception IllegalArgumentException baseNumber is empty */ - NthUglyNumber(int[] baseNumbers) { - if (baseNumbers.length == 0) { + NthUglyNumber(final int[] inBaseNumbers) { + if (inBaseNumbers.length == 0) { throw new IllegalArgumentException("baseNumbers must be non-empty."); } - this.baseNumbers = baseNumbers; - for (final var baseNumber : baseNumbers) { + this.baseNumbers = inBaseNumbers; + for (final var baseNumber : inBaseNumbers) { this.positions.put(baseNumber, 0); } } @@ -41,7 +40,7 @@ public class NthUglyNumber { * @exception IllegalArgumentException n is negative * @return the n-th ugly number (starting from index 0) */ - public Long get(int n) { + public Long get(final int n) { if (n < 0) { throw new IllegalArgumentException("n must be non-negative."); } @@ -67,7 +66,7 @@ private void updatePositions() { } } - private long computeCandidate(int candidateBase) { + private long computeCandidate(final int candidateBase) { return candidateBase * uglyNumbers.get(positions.get(candidateBase)); } From 528982f50b537bdf4bcb54ab9e1188be3005da87 Mon Sep 17 00:00:00 2001 From: Piotr Idzik <65706193+vil02@users.noreply.github.com> Date: Sun, 23 Jul 2023 00:40:08 +0200 Subject: [PATCH 2/3] docs: refer to existing parameter --- src/main/java/com/thealgorithms/maths/NthUglyNumber.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java index 52098fb8871d..bf54e16952cd 100644 --- a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java +++ b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java @@ -21,7 +21,7 @@ public class NthUglyNumber { /** * @brief initialized the object allowing to compute ugly numbers with given base - * @param baseNumbers the given base of ugly numbers + * @param inBaseNumbers the given base of ugly numbers * @exception IllegalArgumentException baseNumber is empty */ NthUglyNumber(final int[] inBaseNumbers) { From 01108390d9d8704e63b7be754d45a6e536108091 Mon Sep 17 00:00:00 2001 From: Piotr Idzik <65706193+vil02@users.noreply.github.com> Date: Sun, 23 Jul 2023 13:06:06 +0200 Subject: [PATCH 3/3] style: use the name `baseNumbers` --- .../java/com/thealgorithms/maths/NthUglyNumber.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java index bf54e16952cd..103ff504ad14 100644 --- a/src/main/java/com/thealgorithms/maths/NthUglyNumber.java +++ b/src/main/java/com/thealgorithms/maths/NthUglyNumber.java @@ -21,16 +21,16 @@ public class NthUglyNumber { /** * @brief initialized the object allowing to compute ugly numbers with given base - * @param inBaseNumbers the given base of ugly numbers + * @param baseNumbers the given base of ugly numbers * @exception IllegalArgumentException baseNumber is empty */ - NthUglyNumber(final int[] inBaseNumbers) { - if (inBaseNumbers.length == 0) { + NthUglyNumber(final int[] baseNumbers) { + if (baseNumbers.length == 0) { throw new IllegalArgumentException("baseNumbers must be non-empty."); } - this.baseNumbers = inBaseNumbers; - for (final var baseNumber : inBaseNumbers) { + this.baseNumbers = baseNumbers; + for (final var baseNumber : baseNumbers) { this.positions.put(baseNumber, 0); } }