Skip to content

Add FloorTest and clean-up Floor #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 11, 2023
Merged

Add FloorTest and clean-up Floor #4769

merged 6 commits into from
Oct 11, 2023

Conversation

ricardo-ramos-moura
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

vil02
vil02 requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also tidy up the Floor class, namely:

  • remove the main method,
  • mark the class as final,
  • add a private default constructor of Floor, i.e. 
    private Floor() {
}

@vil02 vil02 self-assigned this Oct 11, 2023
@vil02
Copy link
Member

vil02 commented Oct 11, 2023

@siriak please have a look regarding changes in DIRECTORY.md.

@vil02 vil02 changed the title Test for floor Add FloorTest and clean-up Floor Oct 11, 2023
siriak
siriak approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit e9bbf35 into TheAlgorithms:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees

@vil02 vil02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardo-ramos-moura @vil02 @siriak