From 28deddd5d78064274b76df56126c9a72163ad361 Mon Sep 17 00:00:00 2001 From: JayH2018 <42029911+JayH2018@users.noreply.github.com> Date: Tue, 28 Aug 2018 14:36:56 +0800 Subject: [PATCH 1/2] source coding is a little complex --- DataStructures/Trees/LevelOrderTraversal.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/DataStructures/Trees/LevelOrderTraversal.java b/DataStructures/Trees/LevelOrderTraversal.java index 8cb304f18c8f..e20753638212 100644 --- a/DataStructures/Trees/LevelOrderTraversal.java +++ b/DataStructures/Trees/LevelOrderTraversal.java @@ -37,14 +37,10 @@ int height(Node root) return 0; else { - /* compute height of each subtree */ - int lheight = height(root.left); - int rheight = height(root.right); - - /* use the larger one */ - if (lheight > rheight) - return(lheight+1); - else return(rheight+1); + /** + * return the larger one; + */ + return Math.max(height(root.left),height(root.right)) + 1; } } @@ -75,4 +71,4 @@ public static void main(String args[]) System.out.println("Level order traversal of binary tree is "); tree.printLevelOrder(); } -} \ No newline at end of file +} From 2dc86b6a04eaa57dfbea7bac3e80b5d9995b4545 Mon Sep 17 00:00:00 2001 From: Varun Upadhyay Date: Tue, 28 Aug 2018 06:25:55 -0700 Subject: [PATCH 2/2] Update LevelOrderTraversal.java --- DataStructures/Trees/LevelOrderTraversal.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DataStructures/Trees/LevelOrderTraversal.java b/DataStructures/Trees/LevelOrderTraversal.java index e20753638212..1f657d92be97 100644 --- a/DataStructures/Trees/LevelOrderTraversal.java +++ b/DataStructures/Trees/LevelOrderTraversal.java @@ -38,7 +38,7 @@ int height(Node root) else { /** - * return the larger one; + * Return the height of larger subtree */ return Math.max(height(root.left),height(root.right)) + 1; }