Skip to content

Explicitly cast result of Math.pow to int in BinaryToHexadecimal #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2023
Merged

Explicitly cast result of Math.pow to int in BinaryToHexadecimal #4970

merged 2 commits into from
Nov 29, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Nov 29, 2023 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Fixes one of the issues detected by merging #4966.

@vil02 vil02 force-pushed the narrowing_conversion_BinaryToHexadecimal branch from 4392915 to fbea5cc Compare November 29, 2023 17:48
@vil02 vil02 changed the title explicitly cast result of Math.pow to int Cxplicitly cast result of Math.pow to int in BinaryToHexadecimal Nov 29, 2023
@vil02 vil02 marked this pull request as ready for review November 29, 2023 17:53
@vil02 vil02 changed the title Cxplicitly cast result of Math.pow to int in BinaryToHexadecimal Explicitly cast result of Math.pow to int in BinaryToHexadecimal Nov 29, 2023
@vil02 vil02 mentioned this pull request Nov 29, 2023
Merged
6 tasks
@siriak siriak merged commit f8de290 into TheAlgorithms:master Nov 29, 2023
@vil02 vil02 deleted the narrowing_conversion_BinaryToHexadecimal branch November 29, 2023 21:48
This was referenced Nov 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @siriak