Skip to content

style: enable AvoidStarImport in checkstyle #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2024
Merged

style: enable AvoidStarImport in checkstyle #5141

merged 1 commit into from
May 5, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 4, 2024

Related to #5119. Done in a semi automated way.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 mentioned this pull request May 4, 2024
Closed
26 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 37.55%. Comparing base (dc47e0a) to head (842ddaa).

Files Patch % Lines
...rc/main/java/com/thealgorithms/sorts/SwapSort.java 0.00% 5 Missing ⚠️
.../main/java/com/thealgorithms/sorts/SimpleSort.java 20.00% 4 Missing ⚠️
...c/main/java/com/thealgorithms/sorts/GnomeSort.java 50.00% 2 Missing ⚠️
...n/java/com/thealgorithms/sorts/PigeonholeSort.java 0.00% 2 Missing ⚠️
...rc/main/java/com/thealgorithms/sorts/CombSort.java 66.66% 1 Missing ⚠️
...main/java/com/thealgorithms/sorts/PancakeSort.java 66.66% 1 Missing ⚠️
...c/main/java/com/thealgorithms/sorts/ShellSort.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5141      +/-   ##
============================================
- Coverage     37.56%   37.55%   -0.02%     
  Complexity     2364     2364              
============================================
  Files           517      517              
  Lines         15605    15605              
  Branches       2965     2965              
============================================
- Hits           5862     5860       -2     
- Misses         9457     9458       +1     
- Partials        286      287       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 4, 2024 15:03
@vil02 vil02 force-pushed the enable_AvoidStarImport branch from 10f341c to 91cb600 Compare May 4, 2024 16:05
BamaCharanChhandogi
BamaCharanChhandogi approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vil02 vil02 force-pushed the enable_AvoidStarImport branch from 91cb600 to 842ddaa Compare May 5, 2024 18:40
@vil02 vil02 merged commit 414835d into TheAlgorithms:master May 5, 2024
5 checks passed
@vil02 vil02 deleted the enable_AvoidStarImport branch May 5, 2024 18:48
@vil02 vil02 mentioned this pull request May 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BamaCharanChhandogi BamaCharanChhandogi BamaCharanChhandogi approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vil02 @codecov-commenter @BamaCharanChhandogi