Skip to content

style: enable NeedBraces in checkstyle #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2024
Merged

style: enable NeedBraces in checkstyle #5227

merged 4 commits into from
Jun 13, 2024

Conversation

samuelfac
Copy link
Contributor

Relates to #5119

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@samuelfac samuelfac marked this pull request as ready for review June 13, 2024 16:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.53444% with 136 lines in your changes missing coverage. Please review.

Project coverage is 39.02%. Comparing base (51fcc66) to head (74dab3c).

Files Patch % Lines
...com/thealgorithms/datastructures/trees/KDTree.java 51.02% 19 Missing and 5 partials ⚠️
.../thealgorithms/datastructures/trees/AVLSimple.java 0.00% 12 Missing ⚠️
.../java/com/thealgorithms/stacks/PostfixToInfix.java 0.00% 12 Missing ⚠️
...in/java/com/thealgorithms/geometry/GrahamScan.java 38.88% 3 Missing and 8 partials ⚠️
...main/java/com/thealgorithms/io/BufferedReader.java 35.71% 4 Missing and 5 partials ⚠️
...ain/java/com/thealgorithms/sorts/LinkListSort.java 56.25% 3 Missing and 4 partials ⚠️
...ealgorithms/datastructures/queues/LinkedQueue.java 25.00% 5 Missing and 1 partial ⚠️
...thealgorithms/maths/MillerRabinPrimalityCheck.java 66.66% 3 Missing and 3 partials ⚠️
...va/com/thealgorithms/strings/ValidParentheses.java 16.66% 2 Missing and 3 partials ⚠️
...rithms/datastructures/hashmap/hashing/HashMap.java 0.00% 4 Missing ⚠️
... and 21 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5227      +/-   ##
============================================
+ Coverage     38.73%   39.02%   +0.28%     
  Complexity     2390     2390              
============================================
  Files           517      517              
  Lines         15381    15541     +160     
  Branches       2957     2958       +1     
============================================
+ Hits           5958     6065     +107     
- Misses         9136     9189      +53     
  Partials        287      287

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 changed the title style: enable NeedBraces in checkstyle style: enable NeedBraces in checkstyle Jun 13, 2024
@vil02 vil02 merged commit 87b17e0 into TheAlgorithms:master Jun 13, 2024
5 checks passed
@vil02 vil02 mentioned this pull request Jun 13, 2024
Closed
26 tasks
@samuelfac samuelfac deleted the enable_NeedBraces branch June 14, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelfac @codecov-commenter @vil02