From ed31f861d3b8597a55c17fab7d67e24bf34de3fc Mon Sep 17 00:00:00 2001
From: vil02 <65706193+vil02@users.noreply.github.com>
Date: Mon, 13 Jan 2025 17:44:15 +0100
Subject: [PATCH] style: include `PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS`

---
 spotbugs-exclude.xml                          |  3 --
 .../scheduling/SJFScheduling.java             | 28 +++++++++----------
 2 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
index 11f89248018f..d3eff458ea45 100644
--- a/spotbugs-exclude.xml
+++ b/spotbugs-exclude.xml
@@ -114,9 +114,6 @@
     <Match>
         <Bug pattern="BL_BURYING_LOGIC" />
     </Match>
-    <Match>
-        <Bug pattern="PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS" />
-    </Match>
     <Match>
         <Bug pattern="UTWR_USE_TRY_WITH_RESOURCES" />
     </Match>
diff --git a/src/main/java/com/thealgorithms/scheduling/SJFScheduling.java b/src/main/java/com/thealgorithms/scheduling/SJFScheduling.java
index 6d105003e68f..cbbc65a3afc5 100644
--- a/src/main/java/com/thealgorithms/scheduling/SJFScheduling.java
+++ b/src/main/java/com/thealgorithms/scheduling/SJFScheduling.java
@@ -14,6 +14,18 @@ public class SJFScheduling {
     protected ArrayList<ProcessDetails> processes;
     protected ArrayList<String> schedule;
 
+    private static void sortProcessesByArrivalTime(List<ProcessDetails> processes) {
+        for (int i = 0; i < processes.size(); i++) {
+            for (int j = i + 1; j < processes.size() - 1; j++) {
+                if (processes.get(j).getArrivalTime() > processes.get(j + 1).getArrivalTime()) {
+                    final var temp = processes.get(j);
+                    processes.set(j, processes.get(j + 1));
+                    processes.set(j + 1, temp);
+                }
+            }
+        }
+    }
+
     /**
      * a simple constructor
      * @param processes a list of processes the user wants to schedule
@@ -22,22 +34,10 @@ public class SJFScheduling {
     SJFScheduling(final ArrayList<ProcessDetails> processes) {
         this.processes = processes;
         schedule = new ArrayList<>();
-        sortByArrivalTime();
+        sortProcessesByArrivalTime(this.processes);
     }
     protected void sortByArrivalTime() {
-        int size = processes.size();
-        int i;
-        int j;
-        ProcessDetails temp;
-        for (i = 0; i < size; i++) {
-            for (j = i + 1; j < size - 1; j++) {
-                if (processes.get(j).getArrivalTime() > processes.get(j + 1).getArrivalTime()) {
-                    temp = processes.get(j);
-                    processes.set(j, processes.get(j + 1));
-                    processes.set(j + 1, temp);
-                }
-            }
-        }
+        sortProcessesByArrivalTime(processes);
     }
 
     /**