From 74c59d515e28008598f81bb35712acabb652562c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20M=C3=BCller?= <34514239+appgurueu@users.noreply.github.com> Date: Fri, 1 Jul 2022 19:06:10 +0200 Subject: [PATCH 1/2] Fix IsPalindrome Big-O analysis --- String/IsPalindrome.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/String/IsPalindrome.js b/String/IsPalindrome.js index 27dca7151f..60c1c313a4 100644 --- a/String/IsPalindrome.js +++ b/String/IsPalindrome.js @@ -10,7 +10,8 @@ * Big-O Analysis * Time Complexity - O(N) on average and worst case scenario as input is traversed in linear fashion - - O(N) on best case scenario, even when input has length of 1, because toString() method takes O(N) + - O(1) on best case scenario if the input already is a string (otherwise toString() method takes O(N)) + and the first & last characters don't match, triggering an early return * Space Complexity - O(1) */ From 2d43558379d41ddd53108088bf8d69102b7ebd2e Mon Sep 17 00:00:00 2001 From: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Date: Fri, 1 Jul 2022 17:06:39 +0000 Subject: [PATCH 2/2] Updated Documentation in README.md --- DIRECTORY.md | 1 + 1 file changed, 1 insertion(+) diff --git a/DIRECTORY.md b/DIRECTORY.md index 315810f062..3793104e27 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -299,6 +299,7 @@ * [FormatPhoneNumber](String/FormatPhoneNumber.js) * [GenerateGUID](String/GenerateGUID.js) * [HammingDistance](String/HammingDistance.js) + * [IsPalindrome](String/IsPalindrome.js) * [KMPPatternSearching](String/KMPPatternSearching.js) * [LevenshteinDistance](String/LevenshteinDistance.js) * [Lower](String/Lower.js)