Skip to content

Renamed NQueen algorithm files, variables to NQueens #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Renamed NQueen algorithm files, variables to NQueens #1162

merged 2 commits into from
Oct 13, 2022

Conversation

SudhanshuSuman
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Changed the name of NQueen algorithm file from "NQueen.js" to "NQueens.js" in order to amalgamate it with implementations in other languages.
  • Modified the variable names and test file names accordingly.
  • Handled the case when a negative value is provided as board size by raising a RangeError exception and added a test for the same.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@appgurueu appgurueu added the chore General improvement label Oct 10, 2022
@SudhanshuSuman
Copy link
Contributor Author

Hey, @raklaptudirm can you please review this pull request so that it can be merged?

@raklaptudirm raklaptudirm merged commit 10079a7 into TheAlgorithms:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants