added an algo which finds unique element in an array #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
requested changes
Sep 11, 2023
There was a problem hiding this comment.
- Get rid of the changes to
package.jsonorpackage-lock.json. - This is not a general solution as the name currently suggests. It only works if (1) there is exactly one unique element (2) all duplicate elements occur an even number of times.
- This can be written more concisely as
arr.reduce((acc, val) => acc ^ val, 0).
appgurueu
reviewed
Sep 11, 2023
There was a problem hiding this comment.
- Please use a proper JSDoc comment (and don't phrase it as "if the interviewer asks" etc.; that's fluff that should be omitted).
- By "get rid of the changes to
package.jsonandpackage-lock.json" I meant remove the changes to them from this PR, not remove the files.
appgurueu
approved these changes
Sep 21, 2023
raklaptudirm
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.