Skip to content

Test cases project euler 9 #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pomkarnath98
Copy link
Member

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pomkarnath98 pomkarnath98 added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2023
@pomkarnath98
Copy link
Member Author

Added hacktoberfest-accepted labels because of only test cases were added, which are verified.

@appgurueu
Copy link
Collaborator

Could you make all additions of project euler condition checks in a single PR?

@pomkarnath98
Copy link
Member Author

pomkarnath98 commented Oct 23, 2023

Could you make all additions of project euler condition checks in a single PR?

@appgurueu I can make the changes as you mentioned. But the readme file says,

  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

So changing all the Project Euler changes will result in the change into multiple files. That's why I haven't done that yet! Do we need to change that rule?

@appgurueu
Copy link
Collaborator

Could you make all additions of project euler condition checks in a single PR?

@appgurueu I can make the changes as you mentioned. But the readme file says,

* [x]  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

So changing all the Project Euler changes will result in the change into multiple files. That's why I haven't done that yet! Do we need to change that rule?

The "rule" is a bit overly strict, yes. I'd see it more as a guideline, though.

I think that for PRs that don't add or modify algorithms or their tests (e.g. chores like this one), it is absolutely fine to do them "in bulk".

These PRs are also an exception in that since these are all "Project Euler condition checks", it is more of a chore than adding tests normally is, which usually is a different matter as reviewing the tests requires knowledge of the problem the algorithm is supposed to solve.

@pomkarnath98
Copy link
Member Author

Could you make all additions of project euler condition checks in a single PR?

@appgurueu I can make the changes as you mentioned. But the readme file says,

* [x]  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

So changing all the Project Euler changes will result in the change into multiple files. That's why I haven't done that yet! Do we need to change that rule?

The "rule" is a bit overly strict, yes. I'd see it more as a guideline, though.

I think that for PRs that don't add or modify algorithms or their tests (e.g. chores like this one), it is absolutely fine to do them "in bulk".

These PRs are also an exception in that since these are all "Project Euler condition checks", it is more of a chore than adding tests normally is, which usually is a different matter as reviewing the tests requires knowledge of the problem the algorithm is supposed to solve.

I am totally happy to do so @appgurueu, but slightly disagree as the guideline doesn't match with this decision. However, we can do them in a single PR. For now, let's merge these PR (which are already done) and next, I'll try to put all of the Project Euler changes in the single PR.

@raklaptudirm raklaptudirm removed the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 24, 2023
@pomkarnath98 pomkarnath98 mentioned this pull request Oct 24, 2023
11 tasks
@pomkarnath98 pomkarnath98 mentioned this pull request Oct 25, 2023
11 tasks
@raklaptudirm raklaptudirm merged commit 9c07bb1 into TheAlgorithms:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants