Skip to content

Add missing test for KnightTour #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2024
Merged

Add missing test for KnightTour #1598

merged 1 commit into from
Jan 27, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jan 24, 2024

Open in Gitpod know more

Describe your change:

This PR adds a test covering this line:

JavaScript/Backtracking/KnightTour.js

Line 41 in 069803f

return false

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

@vil02 vil02 marked this pull request as ready for review January 24, 2024 17:03
@vil02 vil02 changed the title tests: add missing test for KnightTour Add missing test for KnightTour Jan 24, 2024
@appgurueu appgurueu added the tests Adds or fixes tests; issue that points out bugs in the tests label Jan 24, 2024
@raklaptudirm raklaptudirm merged commit 0e5cf5e into TheAlgorithms:master Jan 27, 2024
@vil02 vil02 deleted the add_tc_for_KnightTour branch January 27, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
tests Adds or fixes tests; issue that points out bugs in the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vil02 @appgurueu @raklaptudirm