Skip to content

Add Boyer-Moore string search algorithm #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 23, 2022

Conversation

ayDavidGitHere
Copy link
Contributor

Add New Algorithm.

@lgtm-com
Copy link

lgtm-com bot commented Apr 20, 2022

This pull request introduces 1 alert when merging 8111a43 into 8fc5390 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@raklaptudirm
Copy link
Member

Fix the raised alerts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2022

This pull request introduces 1 alert when merging 81e72f6 into 9513bcd - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2022

This pull request introduces 1 alert when merging 508f38d into 9513bcd - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

appgurueu
appgurueu previously approved these changes Apr 22, 2022
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@raklaptudirm
Copy link
Member

@ayDavidGitHere Waiting for @appgurueu 's comments to be resolved.

appgurueu
appgurueu previously approved these changes Apr 23, 2022
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format your code with standard.js.

Hopefully! 12 commits to add an algorithm.
@raklaptudirm raklaptudirm requested a review from appgurueu April 23, 2022 09:24
@appgurueu appgurueu changed the title Added Boyer-Moore string searching algorithm Add Boyer-Moore string search algorithm Apr 23, 2022
@appgurueu appgurueu merged commit 7881cb5 into TheAlgorithms:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants