Skip to content

Commit b5a3c29

Browse files
filipecosta90rafie
authored andcommitted
Enabled Pull Request CI Performance info generation and publishing (RedisJSON#911)
* Enabled Pull Request CI Performance info generation and publishing * Updated label triggering to ensure default flow is not canceled (cherry picked from commit 078ac5d)
1 parent 6ff75d5 commit b5a3c29

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

.circleci/config.yml

+10-1
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,16 @@ commands:
315315
--triggering_env << parameters.triggering_env >> \
316316
--push_results_redistimeseries \
317317
--allowed-envs << parameters.allowed_envs >> || true
318-
318+
- run:
319+
name: Generate Pull Request Performance info
320+
command: |
321+
if [[ -n ${CIRCLE_PULL_REQUEST##*/} ]]; then
322+
redisbench-admin compare \
323+
--defaults_filename ./tests/benchmarks/defaults.yml \
324+
--comparison-branch $CIRCLE_BRANCH \
325+
--auto-approve \
326+
--pull-request ${CIRCLE_PULL_REQUEST##*/}
327+
fi
319328
#----------------------------------------------------------------------------------------------------------------------------------
320329

321330
jobs:

.github/workflows/trigger-benchmark.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ jobs:
3131
--header 'Circle-Token: ${{ secrets.CIRCLE_CI_SECRET }}' \
3232
--header 'content-type: application/json' \
3333
--data '{"branch": "${{ github.event.pull_request.head.ref }}",
34-
"parameters": {"run_default_flow":false, "run_benchmark_flow_label":true}}'
34+
"parameters": {"run_default_flow":true, "run_benchmark_flow_label":true}}'

tests/benchmarks/defaults.yml

+7
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,10 @@ exporter:
1515
- "$.Tests.Overall.min_latency_ms"
1616
- '$."ALL STATS".*."Ops/sec"'
1717
- '$."ALL STATS".*."Latency"'
18+
comparison:
19+
metrics:
20+
- "Ops/sec"
21+
- "$.Tests.Overall.rps"
22+
- "$.OverallRates.overallOpsRate"
23+
mode: higher-better
24+
baseline-branch: master

0 commit comments

Comments
 (0)