fix: feature toggle keys iteration (#348)

nunogois · web-flow · commit 39c2a5154a5b · 2025-04-24T15:34:48.000+01:00
* fix: feature toggle keys iteration

* chore: make linter happy

* chore: missing dependency
diff --git a/UnleashClient/loader.py b/UnleashClient/loader.py
@@ -132,7 +132,7 @@ def load_features(
             del feature_toggles[feature]
 
     # Update existing objects
-    for feature in feature_toggles.keys():
+    for feature in list(feature_toggles.keys()):
         feature_for_update = feature_toggles[feature]
         strategies = parsed_features[feature]["strategies"]
 
diff --git a/UnleashClient/periodic_tasks/send_metrics.py b/UnleashClient/periodic_tasks/send_metrics.py
@@ -13,15 +13,15 @@ def aggregate_metrics(
 ) -> dict:
     feature_stats_list = []
 
-    for feature_name in features.keys():
-        if not (features[feature_name].yes_count or features[feature_name].no_count):
+    for feature in features.values():
+        if not (feature.yes_count or feature.no_count):
             continue
 
         feature_stats = {
-            features[feature_name].name: {
-                "yes": features[feature_name].yes_count,
-                "no": features[feature_name].no_count,
-                "variants": features[feature_name].variant_counts,
+            feature.name: {
+                "yes": feature.yes_count,
+                "no": feature.no_count,
+                "variants": feature.variant_counts,
             }
         }
 
@@ -42,8 +42,8 @@ def aggregate_and_send_metrics(
 ) -> None:
     feature_stats_dict = aggregate_metrics(features)
 
-    for feature_name in features.keys():
-        features[feature_name].reset_stats()
+    for feature in features.values():
+        feature.reset_stats()
 
     metrics_request = {
         "appName": app_name,
diff --git a/requirements.txt b/requirements.txt
@@ -23,6 +23,7 @@ pytest-xdist
 responses
 ruff
 tox
+pytz
 
 # - Testing ()
 blinker
diff --git a/tests/unit_tests/test_loader.py b/tests/unit_tests/test_loader.py
@@ -21,11 +21,10 @@ def test_loader_initialization(cache_full):  # noqa: F811
         in_memory_features["GradualRolloutUserID"].strategies[0], GradualRolloutUserId
     )
 
-    for feature_name in in_memory_features.keys():
+    for feature_name, feature in in_memory_features.items():
         if feature_name == "Garbage":  # Don't check purposely invalid strategy.
             break
 
-        feature = in_memory_features[feature_name]
         assert len(feature.strategies) > 0
         strategy = feature.strategies[0]
 
