Skip to content

Relax "Unable to get feature flag toggles" log message #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
povilasb opened this issue Mar 28, 2022 · 6 comments · Fixed by #200
Closed

Relax "Unable to get feature flag toggles" log message #199

povilasb opened this issue Mar 28, 2022 · 6 comments · Fixed by #200

Comments

@povilasb
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. UnleashClient produces these logs periodically:
WARNING: Unable to get feature flag toggles, using cached provisioning.

  1. The source:

    unleash-client-python/UnleashClient/periodic_tasks/fetch_and_load.py

    Line 30 in f5900b8

    LOGGER.warning("Unable to get feature flag toggles, using cached provisioning.")

  2. This is a normal behavior and is triggered when response status code from unleash is 304:

    unleash-client-python/UnleashClient/api/features.py

    Line 62 in f5900b8

    if resp.status_code == 304:

    i.e. no changes have been made to toggles

Describe the solution you'd like

Just use an info log message.
@karls
Copy link

karls commented Mar 31, 2022 •
edited
Loading

You could argue that the log message itself is also a little bit misleading. It's implies that something went wrong — "Unable to get...". In reality the server responded with 304 Not Modified which seems to instruct the client to use the cached version.

I think I'd even have that log level as DEBUG and re-word the message for clarity.

@ivanklee86 ivanklee86 mentioned this issue Apr 2, 2022
Merged
15 tasks
@ivanklee86
Copy link
Collaborator

Good point! I've dropped it to DEBUG and rewrote the message. :)

@ivanklee86
Copy link
Collaborator

This is in v5.1.2 :)

@karls
Copy link

karls commented Apr 2, 2022

Nice! Cheers. :-)

@povilasb
Copy link
Contributor Author

povilasb commented Apr 2, 2022 via email

@Natgho
Copy link

Natgho commented Oct 1, 2024 •
edited
Loading

I think the issue is still persist, it should be silenced;
Unleash/unleash-client-java@f9200c9

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change logging if no feature flags are returned from server Unleash/unleash-client-python
4 participants
@karls @povilasb @Natgho @ivanklee86