From a9a3434cbe1849c947a36d61db9f5c37ddb82ce2 Mon Sep 17 00:00:00 2001 From: Ivan Lee Date: Wed, 20 Nov 2024 07:23:28 +0000 Subject: [PATCH 1/3] Fix permissions for doc publishing. --- .github/workflows/release-docs.yml | 4 +++- .github/workflows/release-package.yml | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release-docs.yml b/.github/workflows/release-docs.yml index 21f1bca0..6cb5dc5c 100644 --- a/.github/workflows/release-docs.yml +++ b/.github/workflows/release-docs.yml @@ -2,11 +2,13 @@ name: Release docs on: push: - branches: ["main"] + branches: ["main", "fix_doc_publishing"] jobs: Build: runs-on: ubuntu-latest + permissions: + contents: write steps: - uses: actions/checkout@v4 - name: Set up Python 3.10 diff --git a/.github/workflows/release-package.yml b/.github/workflows/release-package.yml index 3f4a2235..a6b76613 100644 --- a/.github/workflows/release-package.yml +++ b/.github/workflows/release-package.yml @@ -9,6 +9,7 @@ jobs: runs-on: ubuntu-latest permissions: id-token: write + contents: write environment: pypi steps: - uses: actions/checkout@v4 From 143effbfb53b3e9e459044a7afe826451f86d25b Mon Sep 17 00:00:00 2001 From: Ivan Lee Date: Wed, 20 Nov 2024 07:28:06 +0000 Subject: [PATCH 2/3] Test release (without doing a release). --- .github/workflows/release-docs.yml | 2 +- .github/workflows/release-package.yml | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release-docs.yml b/.github/workflows/release-docs.yml index 6cb5dc5c..85f6c063 100644 --- a/.github/workflows/release-docs.yml +++ b/.github/workflows/release-docs.yml @@ -2,7 +2,7 @@ name: Release docs on: push: - branches: ["main", "fix_doc_publishing"] + branches: ["main"] jobs: Build: diff --git a/.github/workflows/release-package.yml b/.github/workflows/release-package.yml index a6b76613..eff578ce 100644 --- a/.github/workflows/release-package.yml +++ b/.github/workflows/release-package.yml @@ -3,6 +3,8 @@ name: Release package on: release: types: [published] + push: + branches: ["fix_doc_publishing"] jobs: main: @@ -23,10 +25,10 @@ jobs: - name: Build package run: | make build - - name: Publish package to Pypi - uses: pypa/gh-action-pypi-publish@release/v1 - env: - repository-url: https://pypi.org/project/UnleashClient/ + # - name: Publish package to Pypi + # uses: pypa/gh-action-pypi-publish@release/v1 + # env: + # repository-url: https://pypi.org/project/UnleashClient/ - name: Build docs run: | make install-docs From 76f76d3ce77f7f3cca19a62cd05cf729749eb711 Mon Sep 17 00:00:00 2001 From: Ivan Lee Date: Wed, 20 Nov 2024 07:31:03 +0000 Subject: [PATCH 3/3] Revert testing changes. --- .github/workflows/release-package.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release-package.yml b/.github/workflows/release-package.yml index eff578ce..a6b76613 100644 --- a/.github/workflows/release-package.yml +++ b/.github/workflows/release-package.yml @@ -3,8 +3,6 @@ name: Release package on: release: types: [published] - push: - branches: ["fix_doc_publishing"] jobs: main: @@ -25,10 +23,10 @@ jobs: - name: Build package run: | make build - # - name: Publish package to Pypi - # uses: pypa/gh-action-pypi-publish@release/v1 - # env: - # repository-url: https://pypi.org/project/UnleashClient/ + - name: Publish package to Pypi + uses: pypa/gh-action-pypi-publish@release/v1 + env: + repository-url: https://pypi.org/project/UnleashClient/ - name: Build docs run: | make install-docs